refactor(spine): route the task boundary through to_task_kwargs - #70
Merged
Conversation
execute.run_task now overlays ctx.to_task_kwargs() onto the boundary, so RunContext is the authoritative source for the resolved identity + port keys it owns (the rest of args_dict - task_settings, config paths, runtime objects - flows unchanged). to_task_kwargs goes from defined-but-unused to the LIVE frozen boundary projection - the seam later phases use to stop evaluate populating these keys. Verified equivalent: boundary characterization updated, full suite green, and the fixed + sequence tasks run end-to-end through the new boundary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
execute.run_tasknow overlaysctx.to_task_kwargs()onto the boundary, soRunContextis the authoritative source for the resolved identity + port keys it owns. The rest ofargs_dict(task_settings, config paths, runtime objects) flows unchanged.This makes
to_task_kwargsthe live frozen boundary projection (previously defined but unused) — the seam later phases use to stopevaluatepopulating these keys and finally drop them from the dict.Verified equivalent:
test_run_task_boundary) updated to the ctx-sourced contract;--simulate), so real tasks receive the projected values correctly.The
serial_port_*/""andacq_type/session_versionadditions are the documented, falsy-safe / already-resolved keys (see the evaluate characterization).