refactor(spine): preflight reads scalar identity + ports off RunContext - #71
Merged
Conversation
preflight_hardware_check now reads simulate/debug/subject/out_path and the bpod port from the RunContext instead of raw args_dict keys (setup_config and the hook-mutable settings.task.patched stay dict reads - they are not RunContext- owned scalar keys). With this, every msw-core consumer BEFORE the task boundary reads those scalars off ctx, which unblocks dropping the redundant keys from the threaded dict (the boundary re-supplies them via to_task_kwargs). Test _args builds a ctx carrying the scalars, matching real flow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
preflight_hardware_checknow readssimulate/debug/subject/out_pathand the bpod port from theRunContextinstead of rawargs_dictkeys. (setup_configand the hook-mutablesettings.task.patchedstay dict reads — not RunContext-owned scalar keys.)With this, every msw-core consumer before the task boundary reads those scalars off
ctx, which unblocks dropping the redundant scalar keys from the threaded dict — the boundary re-supplies them viato_task_kwargs(#70).No behaviour change; the preflight test's
_argsbuilds a ctx carrying the scalars, matching real flow.