Run continuous CI on main pushes and pull requests - #47
Merged
Conversation
The `continuous` workflow triggered on `push` only, which never fires for pull requests opened from forks. Five of the last fifteen PRs to this repo came from forks, so none of them were compiled or format-checked before review. Scope the push trigger to `main` and add a `pull_request` trigger, matching what MudBlazor/MudBlazor and MudBlazor/TryMudBlazor already do. As a side effect this also stops `continuous` from running on every internal branch push and on tag pushes, where it duplicated work already done by `release`. The trigger is declared in the NUKE `[GitHubActions]` attribute, so `build/Build.cs` is updated alongside the generated YAML to keep the two in sync.
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
continuous.ymltriggers onon: [push]with nopull_requesttrigger. Apushevent never fires for a pull request opened from a fork, so fork PRs land in review with no CI at all — nothing compiled, nothing format-checked.The same trigger also causes the opposite problem:
[push]matches every branch and every tag, so internal branch pushes burn runner time, and a release tag push runscontinuousandreleaseconcurrently over the same commit.Change
This matches the trigger shape already used by
MudBlazor/MudBlazor(build-test-mudblazor.yml) andMudBlazor/TryMudBlazor(build-test-trymudblazor.yml).Because the workflow is generated from the NUKE
[GitHubActions]attribute,build/Build.csis updated in the same commit so a future regeneration doesn't silently revert the trigger. NUKE rejects mixing shorthandOnwith the expandedOn*properties, so both push and pull_request are branch-scoped viaOnPushBranches/OnPullRequestBranches.Interaction with #46
#46 removes NUKE and hand-writes both workflows. If that lands first, this PR needs a trivial rebase: keep the
on:block, drop thebuild/Build.cshunk. If this lands first, #46 should carry the newon:block forward into its rewrittencontinuous.yml.Worth noting for #46's case: restoring the NUKE build project surfaced
System.Security.Cryptography.Xml9.0.0 with seven known high-severity advisories andNuGet.Packaging6.12.1 with one low, pulled in transitively viaNuke.Common.