Run continuous CI on master pushes and pull requests - #42
Merged
Conversation
The `continuous` workflow triggered on a bare `push`, which never fires for pull requests opened from forks — so fork PRs were never built or packed before review. Scope the push trigger to `master` and add a `pull_request` trigger, matching what MudBlazor/MudBlazor and MudBlazor/TryMudBlazor already do. This also stops `continuous` from running on every internal branch push and on tag pushes, where it duplicated the build already performed by `release`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
continuous.ymltriggers on a barepush:with nopull_requesttrigger. Apushevent never fires for a pull request opened from a fork, so fork PRs reach review with nothing built and nothing packed.The same trigger causes the inverse problem: bare
push:matches every branch and every tag. This repo currently has 14 non-default branches, so every push to any of them runs a full restore/build/pack, and a release tag push runscontinuousandreleaseconcurrently over the same commit.This is one of three matching PRs closing the same gap across the org — see MudBlazor/ThemeManager#47 and the corresponding Templates PR. Of the org's active repos, MudBlazor, TryMudBlazor, and Translations already had a
pull_requesttrigger; ThemeManager, Icons, and Templates did not.Change
This matches the trigger shape already used by
MudBlazor/MudBlazor(build-test-mudblazor.yml) andMudBlazor/TryMudBlazor(build-test-trymudblazor.yml), both of which scope push to the default branch and leavepull_requestunscoped.release.ymlandupdate-material-symbols.ymlare untouched.