Repository navigation
test(dungeons): verify encounter doors survive restart - #85
Merged
Merged
Conversation
This was referenced Oct 15, 2026
Mathih13
force-pushed
the
feat/vanilla-compatibility-first-pass
branch
from
October 15, 2026 13:02
c241ec4 to
e65a603
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deadmines had no Package-owned test of encounter progress across a restart. The new durable test completes part of the dungeon, restarts a private persistent Standalone, then finishes the bosses and restarts again. It checks all four doors and their saved encounter states at each step.
The test uses the existing Package API and production kill and gameobject-use paths. Normal Module persistence already preserves the door rows, so no recovery behavior is added. The Smite fixture now checks the issued movement destination because movement finishes on later ticks. Fixture setup refuses imported content, and a missing-door log now identifies the Instance.
What you verified
Local checks used Core tree
5003aca5, based on9be23cd1, with Package revisioncee7c6dinstalled../.github/check-core-tip.shwith all Official Packages: 37 Package API checks, 1,706 Module unit tests and the debug-reducer Wasm build passed.deadmines_doors: the durable test passed through two real process restarts, checking partial and completed encounter progress.deadmines_packagedurable test passed, including the Smite movement assertion.dungeons/.Independent adversarial review passed for the final Package scope. Comment review passed for all seven changed files, including new files, removed comments and retained contracts. README pointers resolve.
What you did not verify
No real-client door animation Verification. These tests cover persistent Standalone restarts; they do not add or claim Instance recreation support.
This PR targets Package
main. It uses the existing Package API and can merge independently of the Core stack.The same-name Core branch provides the paired CI build: behavior evidence inventory.
Models: GPT-6.1 Sol and GPT-6 Astra through Codex, with adversarial review by Claude Opus 5.5 through Claude Agent, in T3 Code.