Repository navigation
fix(gateway): send the vanilla Transfer abort reason - #705
Merged
Merged
Conversation
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failed Transfer sends six body bytes where the 1.12.1 build-5875 client expects one reason byte. The Gateway now writes the vanilla body and sends it even when no destination map is available. It preserves the original failure and ends the World Session.
The expected layout comes from pinned CMaNGOS and LyraCore's pinned Benilla decoder. Tests check exact bytes and Benilla's complete body consumption for known, unknown and missing destination maps.
What you verified
Local checks ran on the combined Core tree at
5003aca5, based on9be23cd1. The reordered stack at8d411c26has the identical tree.Comment review passed for the six changed files, including removed comments and retained contracts around the failure path.
What you did not verify
Retail loading-screen recovery has not been checked. This changes Gateway framing only and adds no schema.
Core review order: Transfer framing → gossip condition Gates → Hunter pet rename → behavior evidence inventory.
This PR targets
mainand contains only its own change. Merge the Core stack in that order.The Deadmines persistence tests change is in the Official Package Collection.
Models: GPT-6.1 Sol and GPT-6 Astra, using Codex through T3 Code.