Repository navigation
refactor(packages): use the named Module API - #81
Conversation
|
Full CI exposed a stale upgrade expectation in I reproduced the failure locally using the CI predecessor Wasm and clean checkouts at its recorded revisions. The test now adds the exact expected default before comparing the full Character row. The original durable test passes. An independent adversarial review checked that changed or missing old fields, unexpected columns, wrong defaults and changed row counts still fail. Core #665 remains unchanged at |
|
The composition job failed in three fixtures after Core #657 moved timed-cast cooldowns to admission. I reproduced all three failures locally.
All three repaired durable tests pass locally against Core |
|
The full durable job found three more stale test assumptions. Each failure reproduced locally against Core
All three repaired durable tests pass locally on |
The Official Packages use Module roots removed by Package API v3. This change moves those calls to the five named roots and uses Actor operations for body restoration and movement stopping.
CI selects the same-name Core branch when present and otherwise uses the compatible Core revision. The local check script runs the Package API lint with the collection installed.
Paired with LyraCoreProject/LyraCore#665 for phase 6 of LyraCoreProject/LyraCore#635. The current-source byte comparison is removed from the companion test; the pinned historical input and durable behavior comparison remain.
Validation with Core
55118071: 1,691 linked Module unit tests, debug compilation, 37 Package API lint tests, Package formatting and seven script tests pass. Three private durable tests pass: controller cutover, remote-target movement, and stopping at the rendered position between ticks.The populated-predecessor upgrade test also passes after it explicitly expects the watched-faction column added by Core #654. It still compares every retained field and rejects unexpected columns. Independent adversarial review confirmed this repair and found no Package behavior regression. All nine CI fallback revisions point to the compatible Core commit.
Full CI also found three fixtures that depended on the old timed-cast cooldown behavior. The companion fixture now keeps an explicit cooldown active after the cast. The recovery fixture verifies cooldown admission, then isolates power readiness while retaining the exact Defense cast. The quest-loop fixture places targets far enough away that ranged casters must cross the existing 150-yard threshold. All three original failures were reproduced locally. Their repaired durable tests and an independent adversarial review pass. The full durable job also exposed stale assertions about a completed cast's bounded action row and cooldown readiness in cast replacement and urgent-heal preemption. Those tests now observe the matching completion event or establish readiness before checking the original behavior. All three failures reproduce locally and their repairs pass with an independent adversarial review. All applicable CI jobs passed on
0b1a90a, including full durable, composition, transfer, capacity, class, target-claim and all three acceptance suites.After Core advanced, all nine fallback revisions were updated to the integrated Core
6e73c274. The Package code and tests are unchanged from0b1a90a. The 1,691 linked Module tests and 37 API lint tests pass with that Core revision. Fresh paired CI is pending on Packages607a4c5.Models: GPT-6 Astra and GPT-6.1 Sol. Harness: Codex in T3 Code.