Repository navigation
refactor(module): narrow the Package API to named operations - #665
Merged
Merged
Conversation
This was referenced Oct 11, 2026
Mathih13
marked this pull request as ready for review
October 11, 2026 07:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packages could depend on whole Module families through broad root exports. This made internal changes part of the Package contract.
Package API v3 names five roots:
actor,hooks,package,tables, andscript_binding. Table exports are explicit. Actor operations now own sessionless body restoration and movement stopping. The Package API lint runs as a named test; the build script retains code generation.Phase 6 of #635. The Official Packages migration uses the matching
t3/issue-635-phase-6branch. Phase 7 remains separate.Validation on
55118071: workspace Clippy, Wasm compilation, and 4,732 local tests pass, including 141 schema-parity tests, 37 API lint tests and seven build-script tests. With Official Packages installed, 1,691 Module unit tests, debug compilation and three private durable tests pass: controller cutover, remote-target movement, and stopping at the rendered position between ticks.Two independent adversarial reviews are clear. Review fixes cover nested import and Unicode alias escapes, raw C strings, and quadratic comment scanning. The reviewers checked the moved Actor operations against their former Package implementations and found no schema or reducer-registration changes. All nine Core CI checks passed. Official Packages full CI exposed stale upgrade and cooldown fixture assumptions; those repairs are in the paired PR. The Core check passed again with Packages
15312b6. Full Official Packages CI passed on0b1a90a, including all durable and acceptance jobs.The branch now includes
mainatce53af37through merge6e73c274. The integration preserves the narrowed Package API and the Hearthstone fix. Independent review found no integration defects. Local verification passes: formatting, 1,570 Core Module tests, 1,691 Module tests with Packages installed, 37 Package API lint tests and all three Hearthstone durable tests. All nine Core CI checks passed on6e73c274. Full Official Packages CI is still running on607a4c5.Models: GPT-6 Astra and GPT-6.1 Sol. Harness: Codex in T3 Code.