Skip to content

ci: refuse a Package API exemption in an official Package - #76

Merged
Mathih13 merged 1 commit into
mainfrom
ci/no-package-api-exempt
Oct 8, 2026
Merged

Mathih13 merged 1 commit into
mainfrom
ci/no-package-api-exempt

Conversation

@Mathih13

@Mathih13 Mathih13 commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

An official Package should call Core only through the Package API. playerbots and dungeons now carry zero // package-api: exempt lines, but nothing kept the count at zero. Core's lint accepts an exemption, so a new one would pass review unnoticed.

This adds a package-api-exemptions job to core-tip.yml. It runs git grep for package-api: exempt over every file in a visible top-level directory, which is every Package including its testsuite. Any match fails the job. A git grep error fails it too. The job needs no Core checkout and runs on every push and PR. The full-ci gating of the bot suites is unchanged.

Verified locally: the check passes on main. With // package-api: exempt test appended to playerbots/src/acceptance_fixture.rs, it fails and prints that line.

Pairs with LyraCoreProject/LyraCore#632, which adds the Core side: a tripwire against Package names in Core source, and a Core CI job that builds the Module with these Packages. Neither PR depends on the other to pass.

Claude Opus 5.5 made these changes through Claude Code.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 22 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: cdfaf835-9946-4517-9603-7a31522e8bfe
📥 Commits

Reviewing files that changed from the base of the PR and between 20160de and ca14209.

📒 Files selected for processing (1)
  • .github/workflows/core-tip.yml
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Mathih13
Mathih13 merged commit be14507 into main Oct 8, 2026
20 checks passed
@Mathih13
Mathih13 deleted the ci/no-package-api-exempt branch October 8, 2026 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant