Repository navigation
ci: refuse a Package API exemption in an official Package - #76
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 22 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An official Package should call Core only through the Package API. playerbots and dungeons now carry zero
// package-api: exemptlines, but nothing kept the count at zero. Core's lint accepts an exemption, so a new one would pass review unnoticed.This adds a
package-api-exemptionsjob tocore-tip.yml. It runsgit grepforpackage-api: exemptover every file in a visible top-level directory, which is every Package including its testsuite. Any match fails the job. Agit greperror fails it too. The job needs no Core checkout and runs on every push and PR. Thefull-cigating of the bot suites is unchanged.Verified locally: the check passes on
main. With// package-api: exempt testappended toplayerbots/src/acceptance_fixture.rs, it fails and prints that line.Pairs with LyraCoreProject/LyraCore#632, which adds the Core side: a tripwire against Package names in Core source, and a Core CI job that builds the Module with these Packages. Neither PR depends on the other to pass.
Claude Opus 5.5 made these changes through Claude Code.
🤖 Generated with Claude Code