Skip to content

test(playerbots): leave the cross-Shard command transport test to Core #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mathih13 merged 4 commits into from
Oct 7, 2026
Merged

test(playerbots): leave the cross-Shard command transport test to Core #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
18c7159
test(playerbots): move the cross-Shard command transport test to Core
Mathih13 Oct 7, 2026
678584a
ci: build against Core e1de66950d21a061611a78b2893d2a85a8c649e1
Mathih13 Oct 7, 2026
09bfff8
ci: build against Core 7e83dc2cfe7af2df8a475cd02d489b7647e853ae
Mathih13 Oct 7, 2026
d5ceb63
ci(playerbots): drop the coordinator step Core now owns
Mathih13 Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions .github/run-playerbots-tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,8 @@ def main() -> int:
environment = os.environ.copy()
environment["LYRACORE_TEST_CORE"] = str(core)
environment.setdefault("CARGO_TARGET_DIR", str(core / "target"))
environment.pop("LYRACORE_COORDINATOR_TEST_SOURCE", None)
cargo = ["cargo", f"+{toolchain}"]
if command == "coordinator":
environment["LYRACORE_COORDINATOR_TEST_SOURCE"] = str(suite / "gateway_coordinator.rs")
cargo += ["test", "--manifest-path", str(core / "Cargo.toml"), "--locked",
"-p", "lyracore-gateway", "--bin", "lyracore-gateway", *arguments]
elif command in {"test", "check", "clippy", "fmt", "generate-lockfile"}:
if command in {"test", "check", "clippy", "fmt", "generate-lockfile"}:
patches = []
for name in ["lyracore-shared", "lyracore-test-support"]:
path = core / "crates" / name
Expand Down
16 changes: 6 additions & 10 deletions .github/workflows/core-tip.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
repository: LyraCoreProject/LyraCore
ref: bf6887d2eeb2f3fb46af41dd2478e3ea47ddf280
ref: 7e83dc2cfe7af2df8a475cd02d489b7647e853ae
path: lyracore
persist-credentials: false

Expand All @@ -59,7 +59,6 @@ jobs:
bash -eu -o pipefail -c '
runner="$GITHUB_WORKSPACE/collection/.github/run-playerbots-tests.py"
python3 "$runner" "$GITHUB_WORKSPACE/lyracore" fmt -- --check
rustfmt +1.93.0 --edition 2021 --check "$GITHUB_WORKSPACE/collection/playerbots/testsuite/gateway_coordinator.rs"
python3 "$runner" "$GITHUB_WORKSPACE/lyracore" clippy --locked --all-targets -- -D warnings
python3 "$runner" "$GITHUB_WORKSPACE/lyracore" test --locked
python3 "$runner" "$GITHUB_WORKSPACE/lyracore" test --locked -- --list
Expand All @@ -85,7 +84,7 @@ jobs:
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
repository: LyraCoreProject/LyraCore
ref: bf6887d2eeb2f3fb46af41dd2478e3ea47ddf280
ref: 7e83dc2cfe7af2df8a475cd02d489b7647e853ae
path: lyracore
persist-credentials: false

Expand Down Expand Up @@ -151,7 +150,7 @@ jobs:
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
repository: LyraCoreProject/LyraCore
ref: bf6887d2eeb2f3fb46af41dd2478e3ea47ddf280
ref: 7e83dc2cfe7af2df8a475cd02d489b7647e853ae
path: lyracore
persist-credentials: false
- name: Install the Rust toolchain and Wasm target
Expand Down Expand Up @@ -659,9 +658,6 @@ jobs:
cargo build --manifest-path "$GITHUB_WORKSPACE/lyracore/Cargo.toml" \
--locked --release --target wasm32-unknown-unknown \
-p lyracore-module --features=debug_reducers
python3 "$GITHUB_WORKSPACE/collection/.github/run-playerbots-tests.py" "$GITHUB_WORKSPACE/lyracore" coordinator --no-fail-fast \
stdb::subscriptions::package_tests \
-- --include-ignored --nocapture --test-threads=1
python3 "$GITHUB_WORKSPACE/collection/.github/run-playerbots-tests.py" "$GITHUB_WORKSPACE/lyracore" test \
--locked \
--test playerbots_rewrite --test playerbots_companion \
Expand Down Expand Up @@ -705,7 +701,7 @@ jobs:
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
repository: LyraCoreProject/LyraCore
ref: bf6887d2eeb2f3fb46af41dd2478e3ea47ddf280
ref: 7e83dc2cfe7af2df8a475cd02d489b7647e853ae
path: lyracore
persist-credentials: false
- name: Install the Rust toolchain and Wasm target
Expand Down Expand Up @@ -927,7 +923,7 @@ jobs:
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
repository: LyraCoreProject/LyraCore
ref: bf6887d2eeb2f3fb46af41dd2478e3ea47ddf280
ref: 7e83dc2cfe7af2df8a475cd02d489b7647e853ae
path: lyracore
persist-credentials: false
- name: Install the Rust toolchain and Wasm target
Expand Down Expand Up @@ -1126,7 +1122,7 @@ jobs:
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
repository: LyraCoreProject/LyraCore
ref: bf6887d2eeb2f3fb46af41dd2478e3ea47ddf280
ref: 7e83dc2cfe7af2df8a475cd02d489b7647e853ae
path: lyracore
persist-credentials: false
- name: Install the Rust toolchain and Wasm target
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/playerbots-capacity.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
with:
repository: LyraCoreProject/LyraCore
# Core supplies the shared private integration fixtures.
ref: bf6887d2eeb2f3fb46af41dd2478e3ea47ddf280
ref: 7e83dc2cfe7af2df8a475cd02d489b7647e853ae
path: lyracore
persist-credentials: false
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/playerbots-class-behavior.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
repository: LyraCoreProject/LyraCore
ref: bf6887d2eeb2f3fb46af41dd2478e3ea47ddf280
ref: 7e83dc2cfe7af2df8a475cd02d489b7647e853ae
path: lyracore
persist-credentials: false
- name: Install pinned Rust and SpacetimeDB
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/playerbots-target-claims.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
repository: LyraCoreProject/LyraCore
ref: bf6887d2eeb2f3fb46af41dd2478e3ea47ddf280
ref: 7e83dc2cfe7af2df8a475cd02d489b7647e853ae
path: lyracore
persist-credentials: false
- name: Install pinned Rust and SpacetimeDB
Expand Down
8 changes: 0 additions & 8 deletions playerbots/testsuite/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,5 @@ imported-world cases require Operator-supplied geometry. Missing inputs fail the

CI runs these suites only on demand. Label a PR `full-ci`, or run the workflow by hand.

`gateway_coordinator.rs` exercises the Gateway's private coordinator seam. Core admits that source
only when `LYRACORE_COORDINATOR_TEST_SOURCE` is set for a test build:

```sh
./.github/check-playerbots.sh /path/to/LyraCore coordinator \
stdb::subscriptions::package_tests -- --include-ignored --test-threads=1
```

The runner keeps build artifacts outside this Package and uses Core's pinned Rust toolchain.
Server evidence does not complete attended acceptance with an unmodified 1.12.1.5875 client.
Loading
Loading