Repository navigation
test(playerbots): leave the cross-Shard command transport test to Core - #75
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 31 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The Gateway coordinator test proved Core's command transport, and it reached Gateway private modules through a Core test-only source selection. Core now owns it and runs it with no Package installed. The issuer fence and the Applied or Unchanged decision are this Package's, and playerbots_orders already covers them, so nothing of the file stays here. CI drops the coordinator runner command and builds against the Core branch. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Mathih13
force-pushed
the
test/coordinator-in-core
branch
from
October 7, 2026 21:47
21bfc5a to
d5ceb63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
playerbots/testsuite/gateway_coordinator.rsproved Core's Companion Order transport across World Shards. To do that it reached Gateway private modules, and Core compiled it into the Gateway only whenLYRACORE_COORDINATOR_TEST_SOURCEnamed the file. A Package test that depends on Gateway internals breaks whenever Core refactors them.LyraCoreProject/LyraCore#630 moves the test into Core and drives it with a neutral fixture command, with no Package installed. This PR deletes the playerbots copy, the
coordinatorcommand inrun-playerbots-tests.py, its two CI lines incore-tip.ymland the README section. The playerbots testsuite now names no Gateway private module.Nothing playerbots-specific stays behind. The file asserted two decisions of the playerbots handler: the issuer fence that answers Superseded, and Unchanged for a repeated order.
playerbots_orderscovers both through the single-Shard fixture reducers.The current-Core
ref:lines pin the Core branch head. Merge LyraCore#630 first, then this PR.Made by Claude Opus 5.5 in Claude Code.
🤖 Generated with Claude Code