[Mathih13]

Core used to hard-code the Companion Order reply command playerbots.order.result. Core now takes the reply name from the Package registration, so playerbots must register it.

orders.rs adds ORDER_RESULT_COMMAND with the same string and passes it to game_client_command! as the new third argument. The addon wire bytes do not change. The testsuite calls the renamed party_command_fixture_* debug reducers. CI pins the paired Core branch head in every workflow that pinned Core main.

The capacity and solo target claim workflows build older Package commits as migration baselines. Those commits use the two-argument marker and no longer compile against the new Core. Each baseline now builds on 0cae6903, the Core main this branch starts from, so the migration still crosses only this change.

Paired with LyraCoreProject/LyraCore#622. Merge Core first, then this PR at once. After the Core merge, the pin can move to the merge commit if the maintainers prefer a main SHA.

The stock-client case playerbots_acceptance_human_and_four_companions_complete_the_fixed_route in playerbots-composition-durable asserts the STC\tv1|playerbots.order.result|0|1/1| reply prefix. It proves the reply bytes did not change.

Local checks against the Core branch: testsuite fmt, clippy with -D warnings and tests pass. The Module union with these Packages compiles, passes 1,865 tests, and builds the debug_reducers wasm.

Made by Claude Opus 5.5 in Claude Code.

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features

  • Companion order commands now report their results through a dedicated command.

• Bug Fixes

  • Updated automated checks to use consistent Core revisions and correctly build baseline comparisons.
  • Improved order and receipt-recovery test coverage using the current party-command behavior.

[coderabbitai]

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 3198af4e-2cb7-4419-99e7-c7abb86a8674

📥 Commits

Reviewing files that changed from the base of the PR and between bda457f and 80e5ef7.

📒 Files selected for processing (4)

• .github/workflows/core-tip.yml
• .github/workflows/playerbots-capacity.yml
• .github/workflows/playerbots-class-behavior.yml
• .github/workflows/playerbots-target-claims.yml

 __________________________________________________
< Turning your WTFs per minute into OMGs per hour. >
 --------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 1343bf2f-a333-4fa7-b905-28f53101e8b4

📥 Commits

Reviewing files that changed from the base of the PR and between 7794b8f and bda457f.

📒 Files selected for processing (7)

• .github/workflows/core-tip.yml
• .github/workflows/playerbots-capacity.yml
• .github/workflows/playerbots-class-behavior.yml
• .github/workflows/playerbots-target-claims.yml
• playerbots/src/orders.rs
• playerbots/testsuite/gateway_coordinator.rs
• playerbots/testsuite/tests/playerbots_orders.rs

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The workflows now pin LyraCore to a newer commit. Order command registration adds a result command string. Gateway coordinator and order tests use party-command fixture reducers instead of playerbots-specific reducers.

Changes

Playerbots integration updates

Layer / File(s)	Summary
Update LyraCore workflow pins .github/workflows/core-tip.yml, .github/workflows/playerbots-*.yml	The listed workflows now check out LyraCore at commit 418c8b17ad817fb0f9483b2210a0ddc7be49aa50.
Register the order result command playerbots/src/orders.rs	Order command registration defines ORDER_RESULT_COMMAND as playerbots.order.result and passes it as the third macro argument.
Use party-command test reducers playerbots/testsuite/gateway_coordinator.rs, playerbots/testsuite/tests/playerbots_orders.rs	The tests use party-command fixture reducers for receipt handling and intent application, driving, finishing, and expiry. The described assertions remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Refactor

Suggested reviewers: perpersen

Merge Risk: ⚪ Minimal · up to bda45

The paired Core pins and existing order-reply name are consistent, and no concrete behavior mismatch was found. Complete the normal paired-Core CI checks before merging.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 71.43% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 3 files. (4 skipped: 4…	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: registering the Companion Order reply name with Core. It matches the implementation and PR objective.

Full details: Docstring Coverage

Explanation

Docstring coverage is 71.43% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 3 files. (4 skipped: 4 unsupported.)

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}