Repository navigation
fix(playerbots): stop a runner halt where the Route Path renders the bot - #61
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
A runner decision that stops a moving bot wrote the stop at the stored position. That position lags the leg between two creature ticks, so the client snapped the bot back. stop_movement now calls creatures::tick::stop_where_rendered and writes the row it returns. A blocked or changed Route Path still keeps the stored point. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 29 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a runner decision stopped a bot between a Route leg end and the next 500 ms creature tick, the bot stopped at the last ticked point. That is up to one tick short of where the client draws it, so the client saw the bot snap back.
stop_movementnow calls Core'screatures::tick::stop_where_rendered(LyraCoreProject/LyraCore#603). It stores, and sends the stop at, the point along the Route Path at the stop time. A blocked or changed path keeps the stored point, as the creature tick does.Two new tests in
playerbots_rewrite:With the runner change reverted, the first test fails: it stores
(1200.0, 1200.0)instead of(1210.47, 1202.71).It stacks on #59, which pins Core with #603. Merge #59 first.
Human check: in a real client, watch a bot on a bent path when a decision interrupts it mid-leg (a cast starts, or the controller switches). It halts where it is drawn, does not snap back, and faces the next waypoint.
Refs LyraCoreProject/LyraCore#570
Made by Claude Opus 5.5 orchestrating Claude Sonnet 5.5 in Claude Code.
🤖 Generated with Claude Code