Repository navigation
A playerbots-durable test can fail at random on a missed or dodged fixture hit #62
Description
Expected. A durable test's fixture should produce a deterministic result, not one that depends on a combat avoidance roll.
Actual (at be14507). playerbots_recovery_records_a_controlled_quest_while_survival_takes_priority calls playerbots_fixture_runner_survival_hit (playerbots/testsuite/tests/playerbots_recovery.rs#L1564) and then asserts the bot's health dropped (playerbots/testsuite/tests/playerbots_recovery.rs#L1588). The fixture (playerbots/src/fixture.rs#L3341, playerbots/src/fixture.rs#L2400) routes the hit through the real combat avoidance pipeline, combat::apply_hit, so a miss or dodge leaves health unchanged and the assert fails. #58 fixed the same pattern for a Mage defense test; this one was not touched.
How it shows. The playerbots-durable CI job fails at random, on an unrelated PR, with no code fault behind it.
Fix direction. Force the hit in the fixture so it always lands, or assert on the hit outcome apply_hit returns instead of comparing health before and after.
Activity
Mathih13 commentedon Oct 3, 2026
A second test failed at random, in the
playerbots-durablejob this time:playerbots_recovery::playerbots_recovery_records_a_controlled_quest_while_survival_takes_priority(tests/playerbots_recovery.rs:1588), on PR #60, run 37138754439, job 111249062662. The otherplayerbots-durablerun for the same head passed. #60 does not touch recovery.The assert checks that health after one
playerbots_fixture_runner_survival_hitis lower than before. If that hit uses the normal melee roll, a miss or dodge leaves health unchanged: the same pattern as the Mage test fixed in #58. The fix is the same: assert the hit outcome, or force the hit in the fixture.[-]test(playerbots): transfer refusal test fails at random in playerbots-composition-durable[/-][+]test(playerbots): two tests fail at random in the durable jobs[/+][-]test(playerbots): two tests fail at random in the durable jobs[/-][+]A playerbots-durable test can fail at random on a missed or dodged fixture hit[/+]