Skip to content

feat(playerbots): expose supported quest world facts - #490

Merged
Mathih13 merged 15 commits into
mainfrom
feat/playerbots-quest-admission
Sep 9, 2026
Merged

Mathih13 merged 15 commits into
mainfrom
feat/playerbots-quest-admission

Conversation

@Mathih13

@Mathih13 Mathih13 commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

Playerbots could not distinguish a stored quest destination from a live target, and the importer read the wrong forward-chain column. Packages also lacked typed GameObject and loot operations.

Add bounded destination reads, typed executor outcomes, atomic loot storage and the corrected ClassicDB chain mapping. Paired Package #28 admits a quest only when every objective has a usable executor and retains its actual ender and content revision.

Validation:

  • Combined CI passed 20 companion, eight provisioning, 11 catalogue and 37 shared durable cases, plus 1,637 Module library tests. The orchestrator verified 68 clean case inputs and 99 attribution records against Core 5e4a336 and Package 2d1f6c5. Tested Package merge e3ceb9b0 has the reviewed tree.
  • Both independent review axes approve the source. Core 7d66267 is rebased onto merged provisioning Core 4353fb7; its complete tree equals the tested 5e4a336 tree and all 15 rebased commits have unchanged patches. All final Core checks passed. Core feat(playerbots): expose supported quest world facts #490 merged as dae05c1b78cfd4b59f24968ec8be41f75ce896d1 with the reviewed tree. Package d422c4e is rebased onto merged provisioning 1a482be; all eight behavior patches and the playerbots source tree are unchanged. Final Package CI passed all 76 durable cases and 1,637 library tests against merged Core. Root verified 68 clean case inputs and 99 attribution records. Package Drinking alcohol never makes a Character drunk #28 merged as 2028771d15c8efe87b50d2b6795315221953055d; its tree equals the reviewed head and tested PR merge a5de9bb7.

The private fixtures use named seeded content and geometry. Fixture ownership refuses existing or imported catalogue data before writes. Imported-world and attended-client evidence remain separate release gates. No production realm was accessed.

Implemented with GPT-5.6 Sol in Codex, with GPT-6 orchestration and independent Spec and Standards review.

@coderabbitai

coderabbitai Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 22 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 18150e9a-7a73-444d-976d-e17c70696b63

📥 Commits

Reviewing files that changed from the base of the PR and between 4353fb7 and 7d66267.

📒 Files selected for processing (9)
  • importer/src/main.rs
  • module/src/actor.rs
  • module/src/creatures/spawn.rs
  • module/src/gameobject.rs
  • module/src/items/ops.rs
  • module/src/loot/mod.rs
  • module/src/loot/tag.rs
  • module/tests/playerbots_quest_catalog.rs
  • module/tests/playerbots_rewrite/runner.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Mathih13
Mathih13 force-pushed the feat/playerbots-quest-admission branch 4 times, most recently from 4fdcbd6 to 5e4a336 Compare September 8, 2026 23:36
@Mathih13
Mathih13 force-pushed the feat/playerbots-quest-admission branch from 5e4a336 to 7d66267 Compare September 8, 2026 23:57
@Mathih13
Mathih13 merged commit dae05c1 into main Sep 9, 2026
7 checks passed
@Mathih13
Mathih13 deleted the feat/playerbots-quest-admission branch October 11, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant