Repository navigation
feat(playerbots): expose supported quest world facts - #490
Merged
Merged
Conversation
|
Warning Review limit reachedNext included review available in 22 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (9)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Mathih13
force-pushed
the
feat/playerbots-quest-admission
branch
4 times, most recently
from
September 8, 2026 23:36
4fdcbd6 to
5e4a336
Compare
added 15 commits
September 8, 2026 23:57
Mathih13
force-pushed
the
feat/playerbots-quest-admission
branch
from
September 8, 2026 23:57
5e4a336 to
7d66267
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Playerbots could not distinguish a stored quest destination from a live target, and the importer read the wrong forward-chain column. Packages also lacked typed GameObject and loot operations.
Add bounded destination reads, typed executor outcomes, atomic loot storage and the corrected ClassicDB chain mapping. Paired Package #28 admits a quest only when every objective has a usable executor and retains its actual ender and content revision.
Validation:
5e4a336and Package2d1f6c5. Tested Package mergee3ceb9b0has the reviewed tree.7d66267is rebased onto merged provisioning Core4353fb7; its complete tree equals the tested5e4a336tree and all 15 rebased commits have unchanged patches. All final Core checks passed. Core feat(playerbots): expose supported quest world facts #490 merged asdae05c1b78cfd4b59f24968ec8be41f75ce896d1with the reviewed tree. Packaged422c4eis rebased onto merged provisioning1a482be; all eight behavior patches and the playerbots source tree are unchanged. Final Package CI passed all 76 durable cases and 1,637 library tests against merged Core. Root verified 68 clean case inputs and 99 attribution records. Package Drinking alcohol never makes a Character drunk #28 merged as2028771d15c8efe87b50d2b6795315221953055d; its tree equals the reviewed head and tested PR mergea5de9bb7.The private fixtures use named seeded content and geometry. Fixture ownership refuses existing or imported catalogue data before writes. Imported-world and attended-client evidence remain separate release gates. No production realm was accessed.
Implemented with GPT-5.6 Sol in Codex, with GPT-6 orchestration and independent Spec and Standards review.