Repository navigation
feat(playerbots): gate bot control and verify durable objectives - #484
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (26)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change adds character-owned sessionless action consent, World Shard admission gates, structured party outcomes, generated Gateway bindings, character transfer handling, and integration tests for party and bot behavior. ChangesSessionless consent and bot admission
Priority: ➖ Normal — Schedule the playerbot control change because it spans consent gating, World Shard admission, durable objectives, and party behavior across Core, Package, and Gateway. Estimated code review effort: 4 (Complex) | ~60 minutes Merge Risk: ⚪ Minimal · up to No remaining issue blocks merging this change. Sequence Diagram(s)sequenceDiagram
participant Party as Party flow
participant WorldShard as World Shard
participant Module as Sessionless module
participant RealmCore as Realm-core
Party->>WorldShard: Request sessionless admission
WorldShard->>Module: Validate ownership, session, entity, and consent
Module-->>WorldShard: Return admission outcome
WorldShard-->>Party: Return PartyOutcome
Party->>RealmCore: Accept or decline the group action
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 55.45% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 101 functions across 22 files. (3 skipped: 2 unsupported, 1 too large.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Source review is complete for core StandardsNo remaining findings. Actions now carry their required data, home movement has an explicit target type, Candidate terminology matches the glossary, and the core owns the route expansion limit. Strategy defaults and priority adjustments remain because PB-002 explicitly requires them. SpecNo remaining source findings. Review found and checked fixes for Survival bypassing destination deferral, false stalls during tactical movement, and repeated cycle refusal being mistaken for prerequisite completion. The final serializer correction preserves action data, dispatch, and ordering. The strengthened tactical case pursues away from home, so an arrival-stage change cannot mask the old stall. The ownership case exercises an Account Claim while Final checks are running from clean, fixed commits. Merge still waits for their results, the populated upgrade, and current CI. Earlier runs that overlapped source edits are excluded from final source-identity evidence. Independent standards review used GPT-5.6 Sol; specification review used GPT-6 Astra in Codex. The orchestrator reviewed the complete final encoding correction against both axes. |
Automatic bot invitations could still be accepted after the Package selected RecordOnly or Frozen. A new Account Claim could also arrive before the Character's
onlineflag changed.Put session-less ownership and consent Gates in the Module. The Gateway asks the owning World Shard to admit each automatic group action and distinguishes suppression from unavailable Actors. Controller selection clears unclaimed Group Intents in the same transaction. Consent follows Character Transfer. An action admitted before selection may finish at Realm-core afterwards.
Expose the ownership Gate and optional navigation coverage generation to the Package. Add real durable runner cases for retained return-home objectives, interruption and cancellation, bounded scheduling, explanations, human ownership handoff, and populated migration from the pinned preceding Wasm. The paired Package implements the runner: LyraCoreProject/packages#26.
Validation: clean Package union at Core
41488bfand Package584d01bpassed 1,631 library tests, 1,632 with debug reducers, 31 real action/runner cases, two personality cases and five consent cases. The migration published populated preceding Wasm and upgraded the same private database. Every runtime input record reports clean source trees and Wasm BLAKE370b3d7ea1d39a79b947f3cf69078ed45c0775e2bec7218d3d611e412579e6a0c.Current-head CI passed default Module, Gateway, importer/shared suites, formatting, Clippy, Wasm and Gateway binding parity. Both standards and specification reviews are clear. All Core workflow jobs, including the full durable suite, passed.
Implemented with GPT-6 Astra in the Codex harness. Independent standards review uses GPT-5.6 Sol; specification review uses GPT-6 Astra.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation