Skip to content

fix: open desktop sidebar help menu to the right #1739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lampese merged 1 commit into from
Oct 19, 2026
Merged

fix: open desktop sidebar help menu to the right #1739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/components/src/components/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,9 @@ and [details group](../../../../.agents/notes/implemented/feature/2026-10-18-sid
and its [layout-handoff follow-up](../../../../.agents/notes/implemented/feature/2026-10-19-boot-shell-layout-handoff.md).

- Sidebar footer: Help (`?`), Archive, Settings, in that order. Help retains the
documentation, GitHub repository, community, GitHub Issues feedback, and bug-report menu; Archive is a direct
documentation, GitHub repository, community, GitHub Issues feedback, and bug-report menu.
Desktop Help opens to the right of its button with bottom edges aligned; mobile Help opens upward.
Archive is a direct
button and becomes the return action while open. Desktop controls are 28px and use
the navigation rows' ink and fills (`sidebarSurface.iconButton`, shared with the
header's icon buttons); mobile actions retain their touch targets. See the
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/loro-sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1671,7 +1671,7 @@ export const LoroSidebar = memo(function LoroSidebar({
</IconButton>
}
/>
<Menu.Content side="top" align="end" className="min-w-[160px]">
<Menu.Content side={isMobile ? 'top' : 'right'} align="end" className="min-w-[160px]">
<Menu.Item icon={BookOpen} onClick={() => onDocsClicked?.()}>
{mergedLabels.docs}
</Menu.Item>
Expand Down
Loading