Repository navigation
fix: open desktop sidebar help menu to the right - #1739
Merged
Merged
Conversation
Align the desktop Help popup with the bottom of its trigger and preserve upward placement on mobile. Document the placement in the component README. Model: gpt-6.1-sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Internal same-repository change; no linked issue.
Problem / pressure
The sidebar Help (
?) menu opens above the button and extends to its left. Users want the menu on the button's right side.Summary
Open desktop Help to the right of its trigger, with the bottom edges aligned. Keep mobile Help opening upward and document the placement in the components README.
Visual explanation
Simple change: this changes one menu placement prop. The before/after table captures the visible behavior.
Before / after
Test plan
NODE_ENV=test pnpm --filter @lody/components exec vitest run tests/loro-sidebar-pinned-section.test.tsx tests/workspace-identity.test.tsx.pnpm format, scoped Oxlint, and whitespace checks passed.pnpm run docs checkreports six existing missing local Kimi/Pi submodule paths in the subagent-events notes. No protected documentation topics are registered.pnpm check: all workspace typechecks, general lint, Effect lint, and script tests passed. The full CLI/components test run was stopped locally after the checks above; it did not complete. CI must finish the full suite.Context handoff
Internal same-repository branch. This PR contains only the menu placement change and its README explanation.