Repository navigation
🎲 test: Make the ClickHouse Pinned-Pair Check Order-Independent - #17192
Merged
berry-13 merged 1 commit intoOct 17, 2026
Merged
Conversation
berry-13
force-pushed
the
followup/292-pr-16821-make-the-clickhouse-pinned-pair-check-o
branch
from
October 16, 2026 19:39
971d9e2 to
03ec3c4
Compare
berry-13
marked this pull request as ready for review
October 16, 2026 22:51
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
5 tasks done
berry-13
deleted the
followup/292-pr-16821-make-the-clickhouse-pinned-pair-check-o
branch
October 17, 2026 17:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
In the ClickHouse palette spec, the last test ("pins every pair that sits below its floor") compared the pinned Click UI pairs against
measuredBelow, a module-level Set that the earlier tests filled as a side effect. If you ran that test alone by name (-t), or Jest ran the file in a different order, the Set was empty and the test failed whatever the palette was. Closes berry-13#292.The contrast checks are now one declared matrix,
floorChecks, with one entry per palette test. Each palette test asserts its own entry. The pinning test measures the whole matrix itself, so it reaches the same verdict alone, shuffled, or in file order. The pairs checked and the floors they are held to have not changed.Type of change
Testing
Tested environments/configuration:
packages/client, run the way a contributor reruns a failureAutomated tests:
npx jest src/theme/themes/clickhouse.spec.tsx: 56 passed-t 'pins every pair'alone: 2 passed, 54 skipped (the same command fails 2 ondev)--randomize --seed=16821: 56 passede2e/specs/mock/scenarios/clickhouse-pinned-pairs.spec.tsruns both invocations as contract scenariosScreenshots / recordings
No user-facing change.
Risk / compatibility
None. This changes a test only.
Checklist