Repository navigation
Conversation
b41526e to
f021fc3
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f021fc3b24
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| expect(output.match(/✓ keeps control boundaries and rings at the 3:1 floor/g)).toHaveLength(2); | ||
| expect(output.match(/✓ pins every pair that sits below its floor/g)).toHaveLength(2); |
There was a problem hiding this comment.
This scenario also passes against the parent revision: both matched Jest titles already existed and passed before rgb-surface-sidebar was added to the boundary background list. Removing the sidebar entry together with its four pins would therefore still produce two matches for each title, so this scenario cannot catch the exact regression it claims to cover; assert a sidebar-specific measured pair or fixture instead.
AGENTS.md reference: AGENTS.md:L53-L53
Useful? React with 👍 / 👎.
Pull Request
Summary
The ClickHouse control-boundary check measured
border-control,border-xheavyand the rings on the primary, secondary, tertiary and dialog surfaces, but not onsurface-sidebar, where the sidebar's controls sit. Closes berry-13#291.The check now includes the sidebar canvas. That surfaces four sub-floor pairs:
border-controlandborder-xheavyon the sidebar, in light and dark. The sidebar uses Click UI's page background (#ffffff light, #1f1f1c dark), so the ratios match thesurface-primaryandsurface-dialogpairs that are already pinned. They are added to the same Click UI pin list under the same owner decision. The palette itself does not change.Type of change
Testing
Tested environments/configuration:
packages/clientAutomated tests:
npx jest src/theme/themes/clickhouse.spec.tsx: 56 passed. Without the four new pins, the boundary test and the pinning test fail in both modes.e2e/specs/mock/scenarios/clickhouse-sidebar-boundaries.spec.tsruns the spec in file order and checks that the boundary and pinning tests pass in both modes.Screenshots / recordings
No user-facing change.
Risk / compatibility
None. This changes tests only. #17192 restructures the same spec into a shared contrast matrix; whichever of the two merges second carries the sidebar canvas into the other's form.
Checklist