Repository navigation
🛋️ feat: Open Subagents Directly from Background Tasks - #17020
Conversation
|
Head: |
|
Head: |
|
Head: |
|
Head: |
|
Head: |
|
Head: |
|
Reviewed head: |
|
@codex review the latest head, final review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review the latest head, final review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e9bc679e21
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Head: |
|
Reviewed head: |
|
@codex review the latest head, final review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ed55a3f089
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Head: |
|
@codex review the latest head, final review |
|
Reviewed head: |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Head: |
|
Reviewed head: |
|
Head: |
|
Reviewed head: |
Summary
The background-task popup's subagent arrow only scrolls to the dispatch call, which fails when that message is not loaded. It now opens the requested durable subagent task directly, without changing the visible chat. The action is labeled “Open subagent”; the popup gains no explanatory footer.
Durable activity retains its own parent context, draft, and accumulated live text/tool activity when the visible conversation changes. Navigation releases parent-stream ownership without clearing the selected task; leaving the chat host clears every invocation. A separate “Go to parent chat” control navigates only when requested. This first slice uses the existing resizable side panel; it does not introduce a second draggable-window implementation. Foreground-only activity still closes on navigation, and leaving the authenticated chat host clears the selection.
How it works
Tool rows keep their existing scroll-to-call behavior. Event-origin subagents retain the actor timeline and pin the requested task. Opening transfers keyboard focus to the panel; closing can return to the task disclosure when the call is not rendered.
Type of change
Testing
Latest head:
530b737474a8b91c1f90a01e9ef4eb4c39a5bb8b.The permission-grant scenario records notification tags and asserts exactly one for its target conversation, rather than counting unrelated reply alerts from shared user history. It observes that reply’s unread dot before granting permission and confirms no notifications were constructed while permission was pending. It reuses the persisted reply timestamp. Production notification code is unchanged.
Passed locally:
Client
npx tsc --noEmitpassed. Independent review of this exact head completed with no findings. CI client typechecking, package/Vite builds, API runtime smoke, and Lighthouse passed. The replacement browser shard 8/10 and other test/static lanes are still running, so the earlier CI failure is not yet confirmed cleared. Full Playwright suites and Lighthouse were not run locally.