Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
5 tasks done
berry-13
force-pushed
the
refactor/chat-event-handlers
branch
from
October 15, 2026 15:53
c1024f9 to
2900a42
Compare
berry-13
added this pull request to stack #17153
October 15, 2026 16:13
berry-13
force-pushed
the
refactor/chat-event-handlers
branch
from
October 16, 2026 19:38
2900a42 to
8f31f21
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
useEventHandlers.ts(1,352 lines) held every handler the chat stream renders through: the turn-opening ones (legacy text, sync, created, title), the final handler, the error, cancel and abort paths, the pure error-turn builders, and the setup that wires the step, content and attachment handlers. One file for all of it made each handler hard to review and kept the file far over the chat package's size budget.This splits it by responsibility in
client/src/hooks/SSE/:turns.ts(the error-turn builders and the conversation title rule),useTurnHandlers(text, sync, created, title),useFinalHandler(the final handler and the early-abort restore), anduseAbortHandlers(error, cancel and abort). They share oneEventHandlerContext(handlers.ts) thatuseEventHandlersbuilds from the values it already read;useEventHandlers.tskeeps that setup and is now 277 lines, every new file under 400. No behavior changes. Stacked on #17134.Open PRs #17020 and #16451 touch
finalHandlerand the subagent reset in this file; their changes apply unchanged to the moved code inuseFinalHandler.tsanduseEventHandlers.ts.Type of change
Testing
Tested environments/configuration:
Not applicable: the handlers are moved, not changed.
Automated tests:
useEventHandlers.spec.tsimportsresolveErrorTurnfromturns.ts; nothing else in the specs changed.client, the hooks/SSE specs (useEventHandlers, its cancel spec, titles, workspace, useResumableSSE, transport) plus hooks/Chat and data-provider/SSE: 1148 pass.npx tsc --noEmitinclient, eslint, prettier and sort-imports on the changed files: clean.Screenshots / recordings
No user-facing change.
Risk / compatibility
None.
Checklist