Repository navigation
Conversation
daker
force-pushed
the
webgpu-hardware-selector
branch
from
October 5, 2026 10:28
1aed509 to
922c52d
Compare
49 of 56 tasks
daker
force-pushed
the
webgpu-hardware-selector
branch
from
October 5, 2026 13:13
922c52d to
eed9470
Compare
sankhesh
approved these changes
Oct 12, 2026
Add setArea and clearArea to the WebGPU selector. A flag records that an area was set, so an area of all zeros reads the pixel at the origin. With no area, captureBuffersAsync reads all the window. getSourceDataAsync copies only the color pixels of the area, and the depth copy stays full size. captureBuffersAsync keeps the data, and then getPixelInformation, generateSelection and isPropHit read it synchronously. Fix endSelection and destroy the read back buffers after use. Move the nearest pixel search and the selection build to Core/HardwareSelector/PixelSelectionHelper, and the view and renderer check and preRender call to vtkHardwareSelector.prepareCapture. Both backends use them. Move PassTypes to Core/HardwareSelector/Constants, so Core/Mapper does not import from OpenGL. OpenGL/HardwareSelector/Constants is deprecated. The Unicam rotate manipulator uses the point picker on WebGPU.
daker
force-pushed
the
webgpu-hardware-selector
branch
from
October 15, 2026 08:33
eed9470 to
6d186a7
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Results
Changes
Add setArea to the WebGPU selector. getSourceDataAsync copies only the
color pixels of the area, and the depth copy stays full size.
captureBuffersAsync keeps the data, and then getPixelInformation,
generateSelection and isPropHit read it synchronously. Fix endSelection
and destroy the read back buffers after use.
Move the nearest pixel search and the selection build to
Core/HardwareSelector/PixelSelectionHelper, and the view and renderer
check and preRender call to vtkHardwareSelector.prepareCapture. Both
backends use them.
Move PassTypes to Core/HardwareSelector/Constants, so Core/Mapper does
not import from OpenGL. OpenGL/HardwareSelector/Constants is deprecated.
The Unicam rotate manipulator uses the point picker on WebGPU.
PR Checklist