Update PSP VFPU1/VFPU4-1.3 instructions#256
Merged
Merged
Conversation
* removed invalid instructions `vdet.s/t/q`, `vcrs.s/p/q`, `vdot.s`, `vhdp.s`, `vscl.s`, `vavg.s`, `vfad.s` * unswapped output encodings for `vdet.p` & `vcrs.t` * fixed `vd` size for `vdot.p/t/q` (was: `vdot.t C103,C201,C201`, now: `vdot.t S103,C201,C201`) * fixed `vd` size for `vhdp.p/t/q` (was: `vhdp.t C103,C201,C201`, now: `vhdp.t S103,C201,C201`) * fixed `vd` size for `vdet.p` (was: `vdet.p C103,C202,C212`, now: `vdet.p S103,C202,C212`) * fixed `vd` size for `vavg.p/t/q` (was: `vavg.t C103,C201,C201`, now: `vavg.t S103,C201,C201`) * fixed `vd` size for `vfad.p/t/q` (was: `vfad.t C103,C201,C201`, now: `vfad.t S103,C201,C201`) Used MWCC to generate expected output for added tests.
Owner
|
Thanks! |
tclamb
added a commit
to tclamb/ppsspp
that referenced
this pull request
Jul 8, 2026
Update armips for VFPU instruction parsing changes: - Kingcom/armips#255 - Kingcom/armips#256 Remove brackets from VFPU instruction `vpfx*` params Rename VFPU instruction `vuc2i.s` to `vuc2ifs.s` Add brackets to VFPU instruction `vpfxd` saturation operations (i.e. [0:1] & [-1:1]) Rename FPU instructions `c.$OP` to `c.$OP.s` Fix VFPU instruction `vuc2ifs.s` `vd` size in disassembly Replace `CC[imm3]` with `imm3` in VFPU instructions `vcmov*` & `bv*` disassembly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote a script to round-trip instructions in PPSSPP and ended up finding a few more irregular instructions.
vdet.s/t/q,vcrs.s/p/q,vdot.s,vhdp.s,vscl.s,vavg.s,vfad.svdet.p&vcrs.tvdsize forvdot.p/t/q(was:vdot.t C103,C201,C201, now:vdot.t S103,C201,C201)vdsize forvhdp.p/t/q(was:vhdp.t C103,C201,C201, now:vhdp.t S103,C201,C201)vdsize forvdet.p(was:vdet.p C103,C202,C212, now:vdet.p S103,C202,C212)vdsize forvavg.p/t/q(was:vavg.t C103,C201,C201, now:vavg.t S103,C201,C201)vdsize forvfad.p/t/q(was:vfad.t C103,C201,C201, now:vfad.t S103,C201,C201)Used MWCC to generate expected output for added tests.