Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/pink-sides-swim.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@khanacademy/perseus-editor": patch
---

Internal: Improved type safety in the WidgetEditor component
10 changes: 6 additions & 4 deletions packages/perseus-editor/src/components/widget-editor.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import SectionControlButton from "./section-control-button";
import ToggleableCaret from "./toggleable-caret";
import WidgetEditorSettings from "./widget-editor-settings";

import type Editor from "../editor";
import type {APIOptions} from "@khanacademy/perseus";
import type {Alignment, PerseusWidget} from "@khanacademy/perseus-core";

Expand Down Expand Up @@ -58,7 +57,10 @@ export function _upgradeWidgetInfo(widgetInfo: PerseusWidget): PerseusWidget {
// with all available transforms applied, but the results of those
// transforms will not be propogated upwards until serialization.
class WidgetEditor extends React.Component<Props, State> {
widget: React.RefObject<Editor>;
widget: React.RefObject<{
serialize(): unknown;
getSaveWarnings?: () => unknown;
}>;

constructor(props: Props) {
super(props);
Expand Down Expand Up @@ -86,7 +88,7 @@ class WidgetEditor extends React.Component<Props, State> {
};

_handleWidgetChange = (
newProps: Props,
newOptions: PerseusWidget["options"],
cb: () => unknown,
silent: boolean,
) => {
Expand All @@ -96,7 +98,7 @@ class WidgetEditor extends React.Component<Props, State> {
options: {
...this.state.widgetInfo.options,
...(this.widget.current?.serialize() ?? {}),
...newProps,
...newOptions,
},
} as PerseusWidget;
this.props.onChange(newWidgetInfo, cb, silent);
Expand Down