Fix type issues in WidgetEditor - #4090
Merged
Merged
Conversation
Contributor
npm SnapshotWant to try this PR's changes before it merges? Comment |
Contributor
|
Size Change: +1 B (0%) Total Size: 519 kB 📦 View Changed
ℹ️ View Unchanged
|
handeyeco
approved these changes
Aug 19, 2026
…pe safety in the WidgetEditor component
benchristel
force-pushed
the
benc/fix-widget-editor-types
branch
from
August 20, 2026 16:22
f1f07bc to
66e013a
Compare
Merged
benchristel
pushed a commit
that referenced
this pull request
Aug 20, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/perseus@84.3.0 ### Minor Changes - [#4100](#4100) [`f533e12`](f533e12) Thanks [@benchristel](https://github.com/benchristel)! - The Definition widget now contrasts more clearly with surrounding text, especially in dark mode. ### Patch Changes - [#3983](#3983) [`8e55ded`](8e55ded) Thanks [@handeyeco](https://github.com/handeyeco)! - Some text changes for the NumericInput examples ## @khanacademy/perseus-editor@37.1.1 ### Patch Changes - [#4087](#4087) [`9912a5c`](9912a5c) Thanks [@benchristel](https://github.com/benchristel)! - Internal: the WidgetEditor now receives the entire `PerseusWidget` object via a `widgetInfo` prop, instead of having the properties of `PerseusWidget` spread into its props. - [#4090](#4090) [`ddab64b`](ddab64b) Thanks [@benchristel](https://github.com/benchristel)! - Internal: Improved type safety in the WidgetEditor component - Updated dependencies \[[`f533e12`](f533e12), [`8e55ded`](8e55ded)]: - @khanacademy/perseus@84.3.0 Author: khan-actions-bot Reviewers: benchristel Required Reviewers: Approved By: benchristel Checks: ✅ 11 checks were successful Pull Request URL: #4102
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The general lack of typechecking in the editors meant that these issues went
unnoticed. The new types are more accurate.
Issue: none
Test plan:
Typechecking should pass.