Repository navigation
Sorting options - #331
Open
maryLLay wants to merge 16 commits into
Open
Sorting options#331maryLLay wants to merge 16 commits into
maryLLay wants to merge 16 commits into
Conversation
Collaborator
There was a problem hiding this comment.
@maryLLay I'm going to add some issues that Claude flagged in a review of the code.
# Conflicts: # .github/actions/package-lock.json # .github/actions/package.json # package-lock.json
The sort options lived inside FilterMenu, which coupled them to the tag-filter drawer on small screens and made the sidebar spacing inconsistent with SearchInput. SortMenu now renders standalone on the projects page, matching the SearchInput and FilterMenu pattern: a title, a Reset button, and the option list. On small screens the drawer stays tag-filters only. Sort becomes an MUI Select beside the "Filter by tag" button, reusing the Select and Option primitives from ProjectTypeDropdown for consistent styling. The "No sorting" option acts as the reset there, so no separate button is needed. The ecosystems page never wired up sortedTitlesMap, so the sort options that previously rendered there did nothing. They no longer render on that page.
The "Filter by tag" heading and Reset button were hidden below the md breakpoint, so the drawer had no label. The header now shows on all screen sizes. On md+ the header top padding and the empty bottom button row added extra height, so the gap between the filter list and the sort menu didn't match the gap between the search input and the filter list. Both gaps are now 32px.
Collaborator
🚩 Potential issue - invalid frontmatterOne or more of your committed Markdown files might be missing frontmatter or have an invalid structure. If your PR is to add or edit a project file, please double-check your frontmatter is wrapped in triple dashes (---).
|
🎉 Thank you for your contribution!The website maintainers will review your PR soon. |
One renamed, deleted, or private repo made the batched query throw and the script exit, so no project dates updated. Recover the partial data from error.data and continue; the per-repo warning below reports the missing repos. Only exit when no data is returned. Addresses review feedback on JaneliaSciComp#331.
Pushes made with GITHUB_TOKEN do not fire on: push workflows, so the site was never redeployed after the weekly date update. Dispatch deploy-to-github-pages.yml explicitly after a successful push, and grant the job actions: write. Addresses review feedback on JaneliaSciComp#331.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added options to sort alphabetically or by most recent update.
Please look at how sort by last update is implemented: I'm not sure this is the best way to pull this off.