Repository navigation
fix: drop trailing space from changed markdown file list - #335
Merged
Merged
Conversation
The previous tr pipeline left a trailing space in all_changed_files, which validate-tags.js split into an empty filename and reported as ENOENT. Let bash word-splitting join the list instead.
🎉 Thank you for your contribution!The website maintainers will review your PR soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #333. The
trpipeline left a trailing space inall_changed_files, sovalidate-tags.jssplit off an empty filename and failed withENOENT: no such file or directory, open ''(see the run on #331). Let bash word-splitting join the list instead, which produces no trailing space.@krokicki