Skip to content

feat: governance token rebind, queue error surfacing, payment link validation - #908

Merged
Nanafancy merged 2 commits into
Ignition-World:mainfrom
NteinPrecious:nteinprecious/issues-857-862-863
Oct 16, 2026
Merged

Nanafancy merged 2 commits into
Ignition-World:mainfrom
NteinPrecious:nteinprecious/issues-857-862-863

Conversation

@NteinPrecious

@NteinPrecious NteinPrecious commented Oct 16, 2026 •

Copy link
Copy Markdown
  • [CONTRACT-045] No contract_hash/deploy helper for multi-instance governance token binding #857: added admin-only GovernanceContract::update_governance_token(new_token) (emits governance_token_updated with old/new token) and a governance_token() getter, so a token migration no longer requires redeploying and losing state.
  • [WEB-001] Dashboard asset balances do not refresh after receiving a payment #858: dashboard balances now refresh as soon as a payment arrives. subscribeToWalletStream falls back to Horizon's per-account payments stream when NEXT_PUBLIC_WALLET_STREAM_URL is unset (and treats unnamed message events as a balance change), and a new invalidateWalletBalances() / walletBalancesInvalidated event makes useWalletBalances reload on demand. The dashboard is a custom hook, not React Query, so the fix lives there.
  • [WEB-005] Transaction queue processor swallows submission errors from the API #862: fixed the root cause of silent queue failures in lib/transactionQueue.ts: addTransaction/updateTransaction shadowed their transaction argument with the IndexedDB transaction and stored that object, so updates (including the stored lastError/failed status) could not persist. Added retryQueuedTransaction, a transactionQueueChanged event, and a new TransactionQueueList (shown on the Send page) that lists pending/failed payments with their last error and a Retry button.
  • [WEB-006] Deep-link payment request URL is not validated before navigation #863: new parsePaymentRequest (lib/stellar/paymentRequest.ts) validates an incoming link's destination with validateStellarAddress and sanitises amount/memo; SendPage prefills from ?destination=... when valid and shows an inline alert for an invalid link instead of passing it on. Added tests/payment-request.test.ts. The repo had no existing deep-link handler, so this adds one on the Send page.

Nothing was installed, built or tested (the contract and frontend were not compiled or run); please verify in CI/review.

Closes #857
Closes #858
Closes #862
Closes #863

@drips-wave

drips-wave Bot commented Oct 16, 2026

Copy link
Copy Markdown

@NteinPrecious Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Nanafancy
Nanafancy merged commit 3189687 into Ignition-World:main Oct 16, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants