Repository navigation
feat: governance token rebind, queue error surfacing, payment link validation - #908
Merged
Nanafancy merged 2 commits intoOct 16, 2026
Conversation
|
@NteinPrecious Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
contract_hash/deployhelper for multi-instance governance token binding #857: added admin-onlyGovernanceContract::update_governance_token(new_token)(emitsgovernance_token_updatedwith old/new token) and agovernance_token()getter, so a token migration no longer requires redeploying and losing state.subscribeToWalletStreamfalls back to Horizon's per-account payments stream whenNEXT_PUBLIC_WALLET_STREAM_URLis unset (and treats unnamedmessageevents as a balance change), and a newinvalidateWalletBalances()/walletBalancesInvalidatedevent makesuseWalletBalancesreload on demand. The dashboard is a custom hook, not React Query, so the fix lives there.lib/transactionQueue.ts:addTransaction/updateTransactionshadowed theirtransactionargument with the IndexedDB transaction and stored that object, so updates (including the storedlastError/failedstatus) could not persist. AddedretryQueuedTransaction, atransactionQueueChangedevent, and a newTransactionQueueList(shown on the Send page) that lists pending/failed payments with their last error and a Retry button.parsePaymentRequest(lib/stellar/paymentRequest.ts) validates an incoming link'sdestinationwithvalidateStellarAddressand sanitisesamount/memo;SendPageprefills from?destination=...when valid and shows an inline alert for an invalid link instead of passing it on. Addedtests/payment-request.test.ts. The repo had no existing deep-link handler, so this adds one on the Send page.Nothing was installed, built or tested (the contract and frontend were not compiled or run); please verify in CI/review.
Closes #857
Closes #858
Closes #862
Closes #863