chore: finish the CI cleanup round - #195
Merged
Merged
Conversation
- perf-regression.yml installs with -c constraints/ci.txt like the other gating jobs (left out of #194 to avoid conflicting with #193). - MissForest convergence converts with to_numpy(dtype="float64", na_value=np.nan): the same pandas < 2 masked-array conversion that #192 fixed in the streaming state. Adds a nullable Int16 MissForest test. - contributor-roadmap.md no longer advertises #33 and #31, which are resolved; it points at the good-first-issue label instead.
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
FreshData benchmark report —
|
| fixture | n_rows | n_cols | p50 s | p95 s | peak MB | repair % | false-repair % | preserve % | trust | monotonic | export % |
|---|
Authored-code reduction (Metric 6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small follow-ups left over from #187–#194.
perf-regression.ymlnow installs with-c constraints/ci.txt. I left it out of ci: install gating jobs from a constraints file exported from uv.lock #194 on purpose so ci: install gating jobs from a constraints file exported from uv.lock #194 wouldn't conflict with ci: replace the flaky absolute perf gate with a same-run A/B gate #193's rewrite of this workflow. Every gating workflow now installs fromuv.lock.imputation/missforest.py: the convergence check convertsto_numpy(dtype="float64", na_value=np.nan). On pandas 1.5, a plainto_numpy(dtype="float64")raisescannot convert to 'float64'-dtype NumPy array with missing valuesfor a nullable-int series withNA. That's the same pandas < 2 conversion fix: nullable integer streaming stats on pandas < 2 #192 fixed instreaming/_state.py.mainunder pandas 1.5.3, so I can't show a user-facing crash today.test_missforest_imputation.pycase with a nullableInt16column containingNA, run throughimpute="missforest".docs/community/contributor-roadmap.md: stops listing _has_outliers is duplicated in engine/missing.py and engine/model_select.py #33 (_has_outliersis already deduplicated inengine/utils.py) and _coerce_series in schema_drift.py silently produces pd.NA for boolean True/False Python objects #31 (schema_drift.pyno longer exists) as good first issues, and links thegood first issuelabel instead.Verification
pytest tests/test_missforest_imputation.py tests/test_phase5_backcompat.py:ruff check: clean.perf-regression.ymlparses as YAML.perf-regression.yml, manually dispatched onmain(run 34880909138): the same-run A/B gate completed successfully.