Skip to content

Fix issues #1040-#1042: site URL, assets, and script lint - #1062

Merged
Austinaminu2 merged 1 commit into
FlowwStar:mainfrom
darcszn:fix/1040-1042-site-url-eslint-assets
Oct 19, 2026
Merged

Austinaminu2 merged 1 commit into
FlowwStar:mainfrom
darcszn:fix/1040-1042-site-url-eslint-assets

Conversation

@darcszn

@darcszn darcszn commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Centralize the site origin in lib/site.ts, configurable through NEXT_PUBLIC_SITE_URL with https://flowstar.app as the fallback.
  • Use SITE_URL for canonical, Open Graph, sitemap, and share URLs.
  • Document NEXT_PUBLIC_SITE_URL in .env.local.example.
  • Remove five unused placeholder images from public/.
  • Disable no-console and security/detect-non-literal-fs-filename for scripts/**/*.mjs.
  • Document the intentional console.warn in next.config.mjs.

Validation

  • Confirmed the placeholder asset names have no textual references, including in public/sw.js and public/manifest.json.
  • Tests, lint, CI checks, and dependency installation were skipped as requested.

Closes #1040
Closes #1041
Closes #1042

@drips-wave

drips-wave Bot commented Oct 19, 2026

Copy link
Copy Markdown

@darcszn Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Austinaminu2
Austinaminu2 merged commit 2031338 into FlowwStar:main Oct 19, 2026
1 of 7 checks passed

This branch had an error being deployed

1 failed deployment
staging — da33a2a6 Deployed Oct 19, 2026 by darcszn via deploy-staging #355
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants