Skip to content

fix: E2E selector bug, networkidle timeouts on stream detail page #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Austinaminu2 merged 1 commit into from
Oct 18, 2026
Merged

fix: E2E selector bug, networkidle timeouts on stream detail page #1024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions e2e/accessibility.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,9 @@ test.describe('Axe automated scans', () => {
test('stream-detail page passes axe wcag2a/2aa', async ({ page }) => {
await withWallet(page)
await page.goto('/app/stream/test-id')
// wait for any async content to settle
await page.waitForLoadState('networkidle')
// The stream detail page polls, so the network never goes idle — wait for
// the loading skeleton to disappear instead of waitForLoadState('networkidle').
await page.waitForSelector('div.space-y-6.animate-pulse', { state: 'detached' })
await checkA11y(page)
})

Expand Down Expand Up @@ -116,7 +117,9 @@ test.describe('Cancel-stream dialog — keyboard & focus', () => {
test.beforeEach(async ({ page }) => {
await withWallet(page)
await page.goto('/app/stream/1')
await page.waitForLoadState('networkidle')
// The stream detail page polls, so the network never goes idle — wait for
// the loading skeleton to disappear instead of waitForLoadState('networkidle').
await page.waitForSelector('div.space-y-6.animate-pulse', { state: 'detached' })
})

test('Cancel button opens dialog; dialog has role=dialog and aria-modal', async ({ page }) => {
Expand Down Expand Up @@ -339,7 +342,9 @@ test.describe('Fee-estimate dialog — keyboard & focus', () => {
test.beforeEach(async ({ page }) => {
await withWallet(page)
await page.goto('/app/stream/1')
await page.waitForLoadState('networkidle')
// The stream detail page polls, so the network never goes idle — wait for
// the loading skeleton to disappear instead of waitForLoadState('networkidle').
await page.waitForSelector('div.space-y-6.animate-pulse', { state: 'detached' })
})

async function openFeeDialog(page: Page): Promise<boolean> {
Expand Down
2 changes: 1 addition & 1 deletion e2e/contract-integration.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ test.describe('Contract Integration Tests', () => {

test('should validate recipient address format', async ({ page }) => {
await page.goto('/app/create')
const recipientInput = page.locator('input[placeholder*="Recipient"]').or(page.locator('input[placeholder*="recipient"')).first()
const recipientInput = page.getByPlaceholder(/recipient/i).first()

if (await recipientInput.isVisible()) {
await recipientInput.fill('invalid-address')
Expand Down
Loading