Repository navigation
fix: E2E selector bug, networkidle timeouts on stream detail page - #1024
Merged
Merged
Conversation
- contract-integration.spec.ts: fix the malformed CSS selector (missing
closing bracket) in the recipient-address-format test by switching to
getByPlaceholder, which is also more resilient to markup changes.
- accessibility.spec.ts: the stream detail page polls continuously, so
waitForLoadState('networkidle') never resolves and times out after 30s.
Replaced the three networkidle waits scoped to /app/stream/* (the
stream-detail axe scan, and the Cancel-stream and Fee-estimate dialog
beforeEach hooks) with a wait for the loading skeleton to detach.
Verified contracts/streaming/src/lib.rs already has StreamTransferEvent
properly closed and TopUpEvent annotated with #[soroban_sdk::contractevent]
(FlowwStar#139), and already uses a #[contracterror] StreamError enum with
Result<T, StreamError> returns instead of panic! (FlowwStar#1) — no changes needed
for those two.
Closes FlowwStar#902
Closes FlowwStar#901
Closes FlowwStar#139
Closes FlowwStar#1
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
@Ndifreke000 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
1 task
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bundles fixes/verification for four FlowStar issues assigned to me.
contract-integration.spec.ts'sshould validate recipient address formattest used a malformed CSS selector (input[placeholder*="recipient"— missing closing]), which threw a selector parse error. Replaced it withpage.getByPlaceholder(/recipient/i)./app/stream/*) polls continuously, sowaitForLoadState('networkidle')never resolves and times out after 30s. Replaced the threenetworkidlewaits scoped to that page (the stream-detail axe scan, and the Cancel-stream and Fee-estimate dialogbeforeEachhooks inaccessibility.spec.ts) with a wait for the loading skeleton (div.space-y-6.animate-pulse) to detach — a concrete, deterministic signal that the page has finished its initial render instead of waiting on network quiescence.main.StreamTransferEventhas its closing brace andTopUpEventalready carries#[soroban_sdk::contractevent](contracts/streaming/src/lib.rslines ~305-325). No code change needed.main. There are zeropanic!()calls incontracts/streaming/src/lib.rs; a#[contracterror] pub enum StreamErroralready exists and all mutating entry points returnResult<T, StreamError>. No code change needed.Test plan
e2e/contract-integration.spec.tsand confirm the recipient-format test no longer throws a selector parse error.e2e/accessibility.spec.tschromium-desktop and confirm the stream-detail axe scan, Cancel-stream suite, and Fee-estimate suite no longer time out onnetworkidle.cargo teststill passes forcontracts/streaming(no contract code was changed).Closes #902
Closes #901
Closes #139
Closes #1
🤖 Generated with Claude Code