Skip to content

[NO QA] Adopt shared postCodeReviewResults.sh in claude-review #91689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rlinoz merged 1 commit into from
Jun 8, 2026
Merged

[NO QA] Adopt shared postCodeReviewResults.sh in claude-review #91689

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 2 additions & 17 deletions .github/workflows/claude-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ jobs:
- name: Setup Claude review toolkit
if: steps.set-authorized.outputs.IS_AUTHORIZED == 'true'
id: toolkit
uses: Expensify/GitHub-Actions/.github/actions/claude-review-toolkit@43c1b4348cd46637e44064b02f5d316bfab990ee
uses: Expensify/GitHub-Actions/.github/actions/claude-review-toolkit@2b751e9a86d8690f53443cce0ce886079eccea76

- name: Mark review as in progress
if: steps.set-authorized.outputs.IS_AUTHORIZED == 'true'
Expand Down Expand Up @@ -99,22 +99,7 @@ jobs:
env:
GH_TOKEN: ${{ github.token }}
STRUCTURED_OUTPUT: ${{ steps.code-review.outputs.structured_output }}
run: |
if [ -z "$STRUCTURED_OUTPUT" ]; then
echo "::error::Claude Code Action returned empty structured output"
exit 1
fi
COUNT=$(echo "$STRUCTURED_OUTPUT" | jq '.violations | length')
if [ "$COUNT" -eq 0 ]; then
addPrReaction.sh "$PR_NUMBER" "+1"
else
echo "$STRUCTURED_OUTPUT" | jq -c '.violations[]' | while IFS= read -r v; do
PATH_ARG=$(echo "$v" | jq -r '.path')
BODY_ARG=$(echo "$v" | jq -r '.body')
LINE_ARG=$(echo "$v" | jq -r '.line')
createInlineComment.sh "$PR_NUMBER" "$PATH_ARG" "$BODY_ARG" "$LINE_ARG" || true
done
fi
run: postCodeReviewResults.sh "$PR_NUMBER"
Comment thread
kacper-mikolajczak marked this conversation as resolved.

- name: Run Claude Code (docs)
if: steps.set-authorized.outputs.IS_AUTHORIZED == 'true' && steps.filter.outputs.docs == 'true'
Expand Down
Loading