Repository navigation
Conversation
|
|
|
@chrispader This PR is in Draft because target changes are not yet merged. So this will not be in We create draft PRs for each change to keep an eye on CI checks whether Onyx changesdoes not break anything in E/App |
|
Ahh sorry nevermind, i though |
Resolve main conflict and pin react-native-onyx 3.0.115 for Expensify#101085
…le-fallback # Conflicts: # package-lock.json # package.json
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeScreen.Recording.iPhone.17.Pro.02-10-2026.at.11.06.13.PM.mp4iOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
@mountiny This PR got accepted by C+. Can you take a look? |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.3-0 🚀
|
|
@sosek108 how to check the logs for iPhone safari or chrome? If that to be done by remote debugging explain in detail what to check please? |
|
@kavimuru To be honest I didn't think this through. Checking logs on non-dev build is hard. Let's do this way:
|
|
This PR was validated at around 8:40 am EST and email used is testing210790+ghu@gmail.com |
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.5.3-4 🚀
Bundle Size Analysis (Sentry): |
|
@kavimuru Logging is as expected for this one. Thanks! |
Explanation of Change
Bumps
react-native-onyxfrom3.0.113to3.0.115. The bump contains two Onyx PRs:indexedDBglobal is undeclared in private tabs and in Lockdown Mode, so reading it throwsReferenceError: Can't find variable: indexedDB. Onyx never classified that error, never fell back to the in-memory provider, and retried an operation that can never succeed. This adds anUNAVAILABLEerror class so Onyx degrades to memory-only storage and skips the retries.cache-mode: readto theCLAjob in the Onyx repo's.github/workflows/cla.yml, which the newcache-call-unrestrictedactionlint check requires. It is a workflow-only change with no library code or behavior change.No E/App source changes,
package.json/package-lock.jsononly.Fixed Issues
$ #100844
$ https://github.com/Expensify/Expensify/issues/678960
PROPOSAL: N/A (internal fix)
Tests
Onyx #849 is workflow-only and needs no App testing. The steps below cover Onyx #845.
Storage operation skipped retry; the storage engine is unavailable...info logs for writes. NoCan't find variable: indexedDBReferenceError, and noStorage operation failed after N retriesalerts.Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
Nagranie.z.ekranu.2026-09-28.o.12.31.49.mov
MacOS: Chrome / Safari