Skip to content

[Onyx bump] Bump react-native-onyx to 3.0.115 - #101085

Merged
mountiny merged 9 commits into
Expensify:mainfrom
callstack-internal:fix/indexeddb-unavailable-fallback
Oct 5, 2026
Merged

mountiny merged 9 commits into
Expensify:mainfrom
callstack-internal:fix/indexeddb-unavailable-fallback

Conversation

@sosek108

@sosek108 sosek108 commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Bumps react-native-onyx from 3.0.113 to 3.0.115. The bump contains two Onyx PRs:

No E/App source changes, package.json / package-lock.json only.

Fixed Issues

$ #100844
$ https://github.com/Expensify/Expensify/issues/678960
PROPOSAL: N/A (internal fix)

Tests

Onyx #849 is workflow-only and needs no App testing. The steps below cover Onyx #845.

  1. Open the App in iOS Safari or Chrome for iOS in a private tab (or enable Lockdown Mode for the site).
  2. Sign in and navigate around: open a report, send a message, switch chats.
  3. Verify the app works normally (backed by the in-memory provider) instead of failing to load.
  4. Check the console: exactly one degrade log, plus Storage operation skipped retry; the storage engine is unavailable... info logs for writes. No Can't find variable: indexedDB ReferenceError, and no Storage operation failed after N retries alerts.
  5. Repeat in a normal (non-private) tab and verify IndexedDB is still used and nothing degrades.
  • Verify that no errors appear in the JS console

Offline tests

  1. In a private iOS tab (memory-only storage), turn off the network.
  2. Send a message and verify it appears with the offline/pending style.
  3. Restore the network and verify the message sends.
  4. Note: with memory-only storage the queue does not survive a reload. That is the expected consequence of the browser denying persistent storage.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
Nagranie.z.ekranu.2026-09-28.o.12.31.49.mov
MacOS: Chrome / Safari

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

@sosek108 sosek108 changed the title [No QA] Pin Onyx to IndexedDB-unavailable fallback PR [Onyx bump] Pin Onyx to IndexedDB-unavailable fallback PR Sep 16, 2026
@chrispader

Copy link
Copy Markdown
Contributor

@sosek108 Onyx version 3.0.112 has been published. Please let me know when this PR is ready 🙌🏼

#101568 further bumps Onyx to version 3.0.113, so I'll hold on your PR 🙌🏼

@sosek108

Copy link
Copy Markdown
Contributor Author

@chrispader This PR is in Draft because target changes are not yet merged. So this will not be in 3.0.113. So maybe don't wait on me. cc: @fabioh8010

We create draft PRs for each change to keep an eye on CI checks whether Onyx changesdoes not break anything in E/App

@chrispader

Copy link
Copy Markdown
Contributor

Ahh sorry nevermind, i though 3.1.112 was authored by you. Thanks for the clarification!

Resolve main conflict and pin react-native-onyx 3.0.115 for Expensify#101085
@sosek108 sosek108 changed the title [Onyx bump] Pin Onyx to IndexedDB-unavailable fallback PR [No QA][Onyx bump] Pin Onyx to IndexedDB-unavailable fallback PR Sep 28, 2026
@sosek108 sosek108 changed the title [No QA][Onyx bump] Pin Onyx to IndexedDB-unavailable fallback PR [Onyx bump] Pin Onyx to IndexedDB-unavailable fallback PR Sep 28, 2026
@sosek108 sosek108 changed the title [Onyx bump] Pin Onyx to IndexedDB-unavailable fallback PR [Onyx bump] Bump react-native-onyx to 3.0.115 Sep 28, 2026
@sosek108
sosek108 marked this pull request as ready for review September 28, 2026 10:26
@sosek108
sosek108 requested a review from a team as a code owner September 28, 2026 10:26
@melvin-bot
melvin-bot Bot requested review from getusha and removed request for a team September 28, 2026 10:26
@melvin-bot

melvin-bot Bot commented Sep 28, 2026

Copy link
Copy Markdown

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@sosek108
sosek108 marked this pull request as draft September 28, 2026 10:28
@sosek108 sosek108 changed the title [Onyx bump] Bump react-native-onyx to 3.0.115 [Hold][Onyx bump] Bump react-native-onyx to 3.0.115 Sep 28, 2026
@sosek108 sosek108 changed the title [Hold][Onyx bump] Bump react-native-onyx to 3.0.115 [Onyx bump] Bump react-native-onyx to 3.0.115 Sep 30, 2026
@sosek108
sosek108 marked this pull request as ready for review September 30, 2026 07:51
…le-fallback

# Conflicts:
#	package-lock.json
#	package.json
@mountiny
mountiny self-requested a review October 2, 2026 12:57
@getusha

getusha commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
Screen.Recording.iPhone.17.Pro.02-10-2026.at.11.06.13.PM.mp4
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@sosek108

sosek108 commented Oct 5, 2026

Copy link
Copy Markdown
Contributor Author

@mountiny This PR got accepted by C+. Can you take a look?

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mountiny
mountiny merged commit ade1801 into Expensify:main Oct 5, 2026
41 of 43 checks passed
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

OSBotify commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.3-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@kavimuru

kavimuru commented Oct 5, 2026 •

Copy link
Copy Markdown

@sosek108 how to check the logs for iPhone safari or chrome?
Check the console: exactly one degrade log, plus Storage operation skipped retry; the storage engine is unavailable... info logs for writes. No Can't find variable: indexedDB ReferenceError, and no Storage operation failed after N retries alerts.

If that to be done by remote debugging explain in detail what to check please?

@sosek108

sosek108 commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor Author

@kavimuru To be honest I didn't think this through. Checking logs on non-dev build is hard. Let's do this way:

  1. please verify other steps without checking the logs.
  2. share with me test account's email and approximate timeframe of tests. I'll check logs on server

@kavimuru

kavimuru commented Oct 6, 2026

Copy link
Copy Markdown

This PR was validated at around 8:40 am EST and email used is testing210790+ghu@gmail.com

@OSBotify

OSBotify commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 9.5.3-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@sosek108

sosek108 commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

@kavimuru Logging is as expected for this one. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants