Docs updates for E/A#99341 Pay report global reimbursements prompt - #100744
Docs updates for E/A#99341 Pay report global reimbursements prompt#100744MelvinBot wants to merge 1 commit into
Conversation
Co-authored-by: Shridhar Goel <ShridharGoel@users.noreply.github.com>
|
@MelvinBot mark this PR as ready for review |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@kadiealexander Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🤖 Done — this PR is now Ready for review.
|
|
|
||
| --- | ||
|
|
||
| ## How to start Enable Global Reimbursements from the Pay report prompt |
There was a problem hiding this comment.
Readability / heading violation: "How to start Enable Global Reimbursements from the Pay report prompt" is grammatically broken ("start Enable Global Reimbursements"). Rewrite as a clean task-based heading, e.g. ## How to enable global reimbursements from the Pay report prompt. Per HELP_AUTHORING_GUIDELINES.md Section 2, headings must be clear task-based phrases.
|
|
||
| If your workspace has a verified USD business bank account that is not yet enabled for global reimbursements, and the submitter's deposit account is in a currency other than USD, Expensify prompts you at payment time instead of showing an error on the report. | ||
|
|
||
| The prompt is titled **Pay report** and reads: This submitter has a non-USD bank account. Enable global reimbursements to pay the report, or ask them to add a USD bank account. |
There was a problem hiding this comment.
Readability: The quoted prompt text runs directly into the sentence after "reads:", so it is unclear where the UI copy begins and ends. Set the quoted prompt apart (e.g. as a blockquote or in quotation marks) so members can distinguish the exact on-screen text from the surrounding instruction.
HelpDot Documentation ReviewOverall AssessmentThis PR is a focused, well-scoped help-site follow-up to #99341. It adds documentation for the new Pay report modal that prompts approvers to enable global reimbursements when paying a non-USD submitter from a USD business bank account. Two additive changes: a new setup entry-point section in Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cb3005fcb6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| 2. When the **Pay report** prompt appears, select **Enable Global Reimbursements**. | ||
| 3. Complete the business information, agreement, and signer steps described above. | ||
|
|
||
| Selecting **Enable Global Reimbursements** opens the same setup flow you can start from **Account > Wallet**, beginning at the business information step. |
There was a problem hiding this comment.
Document the locked-account branch before promising setup
When the payer's account is locked, selecting Enable Global Reimbursements does not open the setup flow: EnableGlobalReimbursementsPayModal calls showLockedAccountModal() and only navigates to business information in the unlocked branch. Qualify this instruction (and the equivalent claim in the Pay Expenses FAQ) so locked users are not told to expect a wizard they cannot reach.
Useful? React with 👍 / 👎.
Explanation of Change
Help site follow-up to #99341, which replaced the red inline error on the pay report action with a centered Pay report modal when an approver pays a report, the workspace's USD VBBA is not enabled for global reimbursement, and the submitter has a non-USD deposit account. The modal offers Enable Global Reimbursements and Cancel.
Nothing on the help site described this prompt, so admins hitting it had no article to land on. Two focused additions:
docs/articles/new-expensify/wallet-and-payments/Global-Reimbursement-United-States.mdAdds
## How to start Enable Global Reimbursements from the Pay report prompt— the new second entry point into the USD global reimbursement setup flow, what each button does, and the state the report is left in after Cancel.docs/articles/new-expensify/wallet-and-payments/Pay-Expenses.mdAdds an FAQ entry,
## Why do I see a Pay report prompt asking me to enable global reimbursements?, matching the search intent of an admin who just hit the modal. It sits alongside the existing "Why don't I see my bank account when I click Pay?" entry.Authoring compliance and label verification
Applied
docs/HELP_AUTHORING_GUIDELINES.md,docs/HELPSITE_NAMING_CONVENTIONS.md, anddocs/TEMPLATE.md:##, task-based, and start with an action verb or question word.#headings; single workflow per addition; no###or deeper.UI labels verified rather than paraphrased:
common.corpayPayModalTitle,common.enableGlobalReimbursements, andcommon.cancelinsrc/languages/en.tsas consumed bysrc/components/EnableGlobalReimbursementsPayModal.tsx. The prompt sentence is quoted verbatim fromcommon.corpayPayModalPrompt.src/pages/settings/Wallet/WalletPage/index.tsx), so the article's existing Account > Wallet reference stays consistent.npm run spell-changedpasses on both files (0 issues).Fixed Issues
$
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
// These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@ShridharGoel, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.