Skip to content

[Due for payment 2026-10-02] Upgrade react-native-safe-area-context before RN 0.88 bump #101446

Closed

Description

@MelvinBot

Parent issue

Part of #101427 — must land before the main React Native 0.88 / Expo SDK 58 bump PR.

Background

Expo SDK 58 bundles react-native-safe-area-context ~5.9.1. main is on 5.6.2. Safe Area Context declares react-native: *, so it is not gated on the RN bump and can land on the current RN 0.86 / Expo SDK 57 stack. This is a minor bump with no known breaking API changes.

Scope

  • Bump react-native-safe-area-context 5.6.2 → ~5.9.1 in App (and Mobile-Expensify if required for HybridApp parity)
  • Rebase or remove the existing patch under patches/react-native-safe-area-context/, pinned to 5.6.2 in its filename: react-native-safe-area-context+5.6.2+001+fix-removechild-crash-on-unmount.patch — check whether the upstream fix landed between 5.7 and 5.9 so the patch can be dropped rather than rebased

Target

  • react-native-safe-area-context@~5.9.1 (Expo SDK 58 bundled version)

Acceptance criteria

  • App builds on iOS, Android, and web
  • HybridApp builds if Mobile-Expensify changes are needed
  • Safe area insets are correct on notched iOS devices, Android with gesture navigation, and in landscape
  • No removeChild crash regression on unmount (the behavior the patch guards)
  • Patch audit documented: keep, update, or remove
  • No new JS console errors

Notes

  • Keep this PR focused — do not include the RN / Expo version bump here
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. self-assigned this
    on Sep 17, 2026
  2. melvin-bot commented on Sep 21, 2026

    @melvin-bot

    @war-in Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  3. 6 remaining items

  4. changed the title [-]Upgrade react-native-safe-area-context before RN 0.88 bump[/-] [+][Due for payment 2026-10-02] Upgrade react-native-safe-area-context before RN 0.88 bump[/+] on Sep 25, 2026
  5. melvin-bot commented on Sep 25, 2026

    @melvin-bot

    @shubham1206agra

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.93-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-10-02. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  6. melvin-bot commented on Sep 28, 2026

    @melvin-bot

    @shubham1206agra Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  7. melvin-bot commented on Sep 30, 2026

    @melvin-bot

    @shubham1206agra Huh... This is 4 days overdue. Who can take care of this?

  8. collectioneur commented on Oct 1, 2026

    @collectioneur
    Contributor

    This can be closed since a week has passed and no regressions have occurred

  9. melvin-bot commented on Oct 1, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  10. melvin-bot commented on Oct 1, 2026

    @melvin-bot

    Payment Summary

    Resolving PRs:

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  11. shubham1206agra commented on Oct 5, 2026

    @shubham1206agra
    Contributor

    @mallenexpensify Please remove the payment summary from here. Payment will be handled in parent issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staffTask

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions