Skip to content

Support Windows npm launching in Home Assistant release builds #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PrzemyslawKlys merged 1 commit into from
Oct 8, 2026
Merged

Support Windows npm launching in Home Assistant release builds #1062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion PowerForge.Tests/HomeAssistantReleaseTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -786,7 +786,10 @@ internal RecordingProcessRunner(bool mutateTrackedFile) {

public Task<ProcessRunResult> RunAsync(ProcessRunRequest request, CancellationToken cancellationToken = default) {
Requests.Add(request);
if (request.Arguments.SequenceEqual(new[] { "run", "pack" })) {
var command = request.Arguments;
if (command.Take(3).SequenceEqual(new[] { "/d", "/c", "npm" }))
command = command.Skip(3).ToArray();
if (command.SequenceEqual(new[] { "run", "pack" })) {
var release = Path.Combine(request.WorkingDirectory, "release");
Directory.CreateDirectory(release);
File.WriteAllText(Path.Combine(release, "example.js"), "export const value = 1;\n");
Expand Down
20 changes: 15 additions & 5 deletions PowerForge/Services/HomeAssistantRepositoryService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
using System.Collections.Generic;
using System.IO;
using System.IO.Compression;
using System.Runtime.InteropServices;
using System.Text;
using System.Text.Json;
using System.Text.Json.Nodes;
Expand Down Expand Up @@ -127,10 +128,10 @@ internal IReadOnlyList<string> BuildAssets(HomeAssistantRepositorySnapshot snaps
_ = HomeAssistantSemanticVersion.Parse(version);
var root = ResolveRoot(repositoryRoot);
if (snapshot.Kind == HomeAssistantRepositoryKind.LovelacePlugin) {
Run(root, "npm", "ci");
Run(root, "npm", "test");
Run(root, "npm", "run", "check");
Run(root, "npm", "run", "pack");
RunNpm(root, "ci");
RunNpm(root, "test");
RunNpm(root, "run", "check");
RunNpm(root, "run", "pack");

var primaryAsset = Path.Combine(root, "release", snapshot.HacsFileName!);
if (!File.Exists(primaryAsset))
Expand All @@ -151,7 +152,16 @@ internal IReadOnlyList<string> BuildAssets(HomeAssistantRepositorySnapshot snaps
return Array.Empty<string>();
}

private void Run(string workingDirectory, string executable, params string[] arguments) {
private void RunNpm(string workingDirectory, params string[] arguments) {
var executable = "npm";
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows)) {
// Windows ships npm as a command shim. Direct process creation only searches
// for executables; cmd resolves npm.cmd (or a package manager's npm.exe).
// These operands are the fixed build-stage commands above, never user input.
executable = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.System), "cmd.exe");
arguments = new[] { "/d", "/c", "npm" }.Concat(arguments).ToArray();
}

var environment = new Dictionary<string, string?>(StringComparer.OrdinalIgnoreCase) {
["ACTIONS_ID_TOKEN_REQUEST_TOKEN"] = null,
["ACTIONS_ID_TOKEN_REQUEST_URL"] = null,
Expand Down
Loading