Repository navigation
Support Windows npm launching in Home Assistant release builds - #1062
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Home Assistant plugin builds start npm as an executable. Standard Windows Node.js installations expose npm through
npm.cmd, so direct process creation fails before dependency installation begins.Run the four fixed npm build-stage commands through the system Windows command processor with AutoRun disabled. Linux and macOS retain direct npm execution. Credential scrubbing and the test, type-check, and packaging stages remain unchanged; no new dependency or public configuration is introduced.
This was reproduced while building Waste Pickup Planner. PowerForge owns process launching, and the card continues to use the shared release engine.
Validation: 35 focused Home Assistant release/client tests passed. The exact
v0.1.6card release commit was built successfully on Windows and Linux without GitHub write credentials; both produced the same SHA-256 as the published release bundle.