Skip to content

Update test adapter and correct native DNS fixtures #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PrzemyslawKlys merged 3 commits into from
Oct 19, 2026
Merged

Update test adapter and correct native DNS fixtures #584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
068be2e
Bump the all-dependencies group with 1 update
dependabot[bot] Oct 19, 2026
86623d8
Complete native DoQ request streams before replying
PrzemyslawKlys Oct 19, 2026
83883ca
Reserve the DNSCrypt fixture port for UDP and TCP together
PrzemyslawKlys Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DnsClientX.Tests/DnsClientX.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="xunit.runner.visualstudio" Version="4.0.0">
<PackageReference Include="xunit.runner.visualstudio" Version="4.0.1">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
Expand Down
3 changes: 1 addition & 2 deletions DnsClientX.Tests/DnsCryptTestServer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,8 @@ internal sealed class DnsCryptTestServer : IDisposable {
internal DnsCryptTestServer(ushort system = 2) {
System = system;
Certificate = SignedCertificate(system);
_tcp = new TcpListener(IPAddress.Loopback, 0); _tcp.Start();
(_udp, _tcp) = TestUtilities.BindUdpAndTcp();
Endpoint = (IPEndPoint)_tcp.LocalEndpoint;
_udp = new UdpClient(Endpoint);
_udpLoop = ServeUdp(); _tcpLoop = ServeTcp();
}

Expand Down
2 changes: 2 additions & 0 deletions DnsClientX.Tests/NativeEncryptedDnsFixture.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,8 @@ private async Task ServeStreamAsync(QuicStream stream) {
byte[] query = new byte[(prefix[0] << 8) | prefix[1]];
await stream.ReadExactlyAsync(query, _lifetime.Token);
Assert.Equal(0, query[0] | query[1]);
// Consume the request FIN before disposal can abort the client's write side.
Assert.Equal(0, await stream.ReadAsync(new byte[1], _lifetime.Token));
byte[] response = await RespondAsync(query, _lifetime.Token);
prefix[0] = (byte)(response.Length >> 8);
prefix[1] = (byte)response.Length;
Expand Down
Loading