Skip to content

Update test adapter and correct native DNS fixtures - #584

Merged
PrzemyslawKlys merged 3 commits into
mainfrom
dependabot/nuget/DnsClientX.Tests/all-dependencies-9d0a37c85b
Oct 19, 2026
Merged

PrzemyslawKlys merged 3 commits into
mainfrom
dependabot/nuget/DnsClientX.Tests/all-dependencies-9d0a37c85b

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Updates the private xUnit Visual Studio test adapter from 4.0.0 to 4.0.1 and corrects two native DNS test fixtures.

The DoQ loopback peer reads each request through FIN before replying, preserving the strict connection-reuse and TLS/deadline/cancellation/disposal checks. The DNSCrypt peer uses the existing shared helper to reserve one port for both UDP and TCP, avoiding Windows ports that are available for only one protocol.

Validation: related QUIC tests passed on Linux under .NET 8 and .NET 10 (19 passed and one opt-in public-network test skipped per framework). All six hosted QUIC lanes passed on the first repaired head. The DNSCrypt tests pass on Windows under .NET Framework 4.7.2, .NET 8, and .NET 10 (12 per framework, no skips). Normal current-head hosted platform and package checks remain the merge gate. The original intermittent QUIC connection-count failure did not reproduce in bounded local runs, so its cause remains unconfirmed.

Summary by CodeRabbit

  • Tests
    • Updated the test runner and refined encrypted DNS test-server behavior, including request-closure checks and consistent network endpoint setup.
    • These changes improve the reliability of automated testing; no user-facing features or behavior changed.

Bumps xunit.runner.visualstudio from 4.0.0 to 4.0.1

---
updated-dependencies:
- dependency-name: xunit.runner.visualstudio
  dependency-version: 4.0.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added .NET Pull requests that update .NET code dependencies Pull requests that update a dependency file labels Oct 19, 2026
@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 85a461b6-f409-4ee1-adf2-6a5eb1f8a7da
📥 Commits

Reviewing files that changed from the base of the PR and between 86623d8 and 83883ca.

📒 Files selected for processing: 1
  • DnsClientX.Tests/DnsCryptTestServer.cs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

📝 Walkthrough

The test project updates its xunit.runner.visualstudio package reference, changes how DnsCryptTestServer binds UDP and TCP, and requires the encrypted DNS fixture request stream to reach EOF before it generates a response.

Changes: Test infrastructure updates

Layer / File(s) Summary
Update test server setup
DnsClientX.Tests/DnsClientX.Tests.csproj, DnsClientX.Tests/DnsCryptTestServer.cs
The project references xunit.runner.visualstudio version 4.0.1. DnsCryptTestServer initializes its UDP socket, TCP listener, and endpoint through TestUtilities.BindUdpAndTcp().
Require request stream EOF
DnsClientX.Tests/NativeEncryptedDnsFixture.cs
ServeStreamAsync reads after the DNS query and asserts that the stream has reached EOF before generating a response.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Suggested reviewers: przemyslawklys

Merge Risk: ⚪ Minimal · up to 83883

This test-infrastructure update makes the encrypted-DNS fixture wait for request completion, which the DoQ client signals before reading the response. No actionable PR-specific risk remains, subject to normal required checks.

### Architecture Summary

Architecture risk: 🔵 Low · up to 068be

The change affects 1 system.

Changed systems: DnsClientX.Tests

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — DnsClientX.Tests (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in DnsClientX.Tests/DnsClientX.Tests.csproj: Updated the xunit.runner.visualstudio package reference from version 4.0.0 to 4.0.1.
Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes both main changes: updating the test adapter and correcting the native DNS fixtures.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 2
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.20%. Comparing base (521758e) to head (83883ca).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #584      +/-   ##
==========================================
- Coverage   76.21%   76.20%   -0.02%     
==========================================
  Files         315      315              
  Lines       19661    19661              
  Branches     4190     4190              
==========================================
- Hits        14984    14982       -2     
- Misses       2852     2854       +2     
  Partials     1825     1825              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PrzemyslawKlys PrzemyslawKlys changed the title Bump the all-dependencies group with 1 update Update test adapter and complete native DoQ request streams Oct 19, 2026
@PrzemyslawKlys PrzemyslawKlys changed the title Update test adapter and complete native DoQ request streams Update test adapter and correct native DNS fixtures Oct 19, 2026
@PrzemyslawKlys
PrzemyslawKlys merged commit 65f2723 into main Oct 19, 2026
42 of 43 checks passed
@PrzemyslawKlys
PrzemyslawKlys deleted the dependabot/nuget/DnsClientX.Tests/all-dependencies-9d0a37c85b branch October 19, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant