Adds options for frazil coupling type "omega-fluxes" - #43
Merged
Merged
Conversation
njeffery
requested review from
darincomeau,
erinethomas,
karapeterson and
proteanplanet
June 30, 2026 17:49
Member
|
Passes |
Member
Set cpl_frazil to ‘omega-fluxes’ Now consistent with salinity correction in icepack_therm_itd
njeffery
force-pushed
the
njeffery/omega-coupling-frazil
branch
from
September 1, 2026 16:51
30b0620 to
cde2829
Compare
Author
|
@darincomeau : this should be ready to go. It’s rebased with omega-coupling. I did a short test with the companion omega PR (E3SM-Project/Omega#460), and it compiled and ran successfully in debug mode. |
darincomeau
approved these changes
Sep 1, 2026
darincomeau
left a comment
darincomeau
left a comment
Member
There was a problem hiding this comment.
Approved based on my and developer's testing.
Member
|
@proteanplanet @karapeterson @erinethomas can any of you review/approve before I go ahead with the merge? |
|
visual inspection looks good. Approve. |
erinethomas
approved these changes
Sep 1, 2026
karapeterson
approved these changes
Sep 1, 2026
karapeterson
left a comment
karapeterson
left a comment
There was a problem hiding this comment.
Looks good! Successfully built and ran a short test case.
Member
|
Thanks all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a bounds check to ensure bulk salinity >= 0.1 ppt.