UPDATE - Adds new ocean to ice coupling fields for frazil ice formation - #535
darincomeau wants to merge 13 commits into
Conversation
Updates Icepack submodule to frazil coupling branch Adds ocean-ice coupling fields: frazil salt flux (Fioo_frazils) frazil enthalpy flux (Fioo_frazilh) defined consistent with freezingMeltPotential To use, set config_frazil_coupling_type to ‘omega-fluxes’ Backwards compatible with mpas-ocean for config_frazil_coupling_type = ‘external’ Stealth
Sea ice initialize now allows for the config_frazil_coupling_type option: "omega-fluxes"
Sea ice initialize NOW allows for config_frazil_coupling_type option: “omega-fluxes”
Removes double counting of frazil energy in coupler budget. Corrects possible but in temperature tendency of frazil melt. nBFB
Adds optional formulation in frazil.
Revert to original formulation with comments.
1. Initialized frazilMassFlux to 0 for SOM 2. Corrected indexing of component-level salt budget sum 3. Type in comment 4. Corrected definition of Fioo_frazils in MOAB to be consistent with mct
| integer :: index_o2x_Faoo_h2otemp | ||
| integer :: index_o2x_Fioo_frazil | ||
| integer :: index_o2x_Fioo_frazils | ||
| integer :: index_o2x_Fioo_frazils |
There was a problem hiding this comment.
Looks like frazils is in twice and frazilh missing.
| integer :: index_o2x_Faoo_h2otemp | ||
| integer :: index_o2x_Fioo_frazil | ||
| integer :: index_o2x_Fioo_frazils | ||
| integer :: index_o2x_Fioo_frazilh |
There was a problem hiding this comment.
@njeffery i'm not sure how that showed up for you, looks correct here?
There was a problem hiding this comment.
Hmm. Had an outdated version I guess. That's better.
There was a problem hiding this comment.
@darincomeau : I'm fairly sure that this version double counts frazil heat in the total ocean heat budget. Both f_hfrz , which points to the sea ice energy Fioo_q = latent heat, and f_hfrazo, which points to the new accumulated frazil energy for the omega-coupling option, are summed. I'm not sure what the best approach is because the heat used depends on a flag in mpas-seace.
There was a problem hiding this comment.
@jonbob has some suggestions. He'll reach out.
|
Passes |
|
@darincomeau, should we close #460 in favor of this one? |
Yes, @njeffery if out this week, but I think we can close that one. |
|
Thanks, I'll close it for now. We can re-open if needed. |
I think we make note of this for now, but not try to address the coupler budget inconsistency with different mpas-seaice frazil namelist options here (which would likely add a coupler flag and may be premature here?). |
|
Closing in favor of #559 |
4 participants
Updated version of #460 after updates to base
seaice-couplingbranch. Description from that PR: