import timetable from EE - #2780
Conversation
| "djangorestframework==3.16.1", | ||
| "drf-yasg==1.21.11", | ||
| "uk-election-timetables==4.4.0", | ||
| "uk-election-timetables==5.0.0", |
There was a problem hiding this comment.
This might seem like an odd thing to be doing, but in order to write the backfill migration I still need the lib, and it needs to be able to give me the right dates for both close_of_nominations and sopn_publish_deadline. I'll remove this in a follow-up PR
There was a problem hiding this comment.
every time I remember this file exists I get sad
| We expect the official list of candidates to be published on or after | ||
| <strong>{{ ballot.expected_sopn_date }}</strong>.</p> | ||
| {% if ballot.close_of_nominations and ballot.sopn_publish_deadline %} | ||
| We expect the official list of candidates to be published between | ||
| <strong>{{ ballot.close_of_nominations }}</strong> and | ||
| <strong>{{ ballot.sopn_publish_deadline }}</strong> | ||
| {% endif %} |
There was a problem hiding this comment.
This template seems like the one place where we do want to differentiate between close_of_nominations and sopn_publish_deadline but if we think this is just clunky, let me know and I'll put it back to just using close_of_nominations.
b1dc550 to
f0260eb
Compare
c2ad4b9 to
46f70df
Compare
| <p class="clearfix"> | ||
| {% if not ballot.has_sopn %} | ||
| {% include "elections/includes/_ballot_add_candidate.html" with position='left' %} | ||
| {% if ballot.close_of_nominations and ballot.sopn_publish_deadline %} |
There was a problem hiding this comment.
Are there any cases where these are the same?
There was a problem hiding this comment.
Yes. These are always 2 different dates in all the situations we cover
There was a problem hiding this comment.
Assume you mean "No. These..." here 馃憤
symroe
left a comment
symroe
left a comment
There was a problem hiding this comment.
Assuming the logic to show dates doesn't end up showing the same date twice in some situations, I think this is good 馃憤
I think we can delete get_election_timetable in this PR too?
symroe
left a comment
symroe
left a comment
There was a problem hiding this comment.
Sorry, marked as approved by mistake, but I think get_election_timetable needs to be removed
|
The |
Oh I'm sorry, I was looking at the line diffs and didn't notice the whole file was gone 馃憤 |
2 participants
No description provided.