Conversation
Contributor
Author
|
Heads-up on ordering: this and #3106 both edit They remove disjoint sets of urls, so there is no disagreement between them, but they do touch the Adjacent lines, so whichever merges second will likely want a trivial rebase. Merge them in either |
…eir key posted eth_chainId to all 2651 http rpcs in extraRpcs.js. 924 answered with the chainId they are filed under, 19 answered with a different one, and the rest were unreachable and are ignored since that proves nothing. most are a mainnet endpoint under a testnet key or the reverse: 11 metadium mainnet pointed at api.metadium.com/dev which returns 12, and 4002 fantom testnet carried fantom.api.onfinality.io/public which returns 250 while the correct testnet url sits one line away. 224400 and 224433 both pointed at hosts returning 224422, and 16600 and 8691942025 return ids that moved upstream. 12123 to 12131 were a block of drpc endpoints written to a run of sequential keys rather than to the chains they belong to. 12124 to 12131 are not in the upstream chain list at all so nothing rendered them, and 12123 is brc chain mainnet whose only entry was hoodi.drpc.org returning 560048. each of those urls is valid for the chain named in its own hostname, just filed in the wrong place, so removing the keys leaves upstream's own rpcs in place. 2014 and 5577 had no other rpc so the keys go with the entry. left 2522 fraxtal testnet alone: both its endpoints now return 2523, which exists upstream as fraxtal hoodi testnet, so whether they move or get dropped is a call for you. Fixes DefiLlama#3168
0xshubhs
force-pushed
the
rpc-chainid-mismatch
branch
from
October 5, 2026 05:40
b870341 to
7c11641
Compare
atze1210
approved these changes
Oct 5, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evidence and the full table are in #3168.
Posted
eth_chainIdto all 2,651 http rpcs inconstants/extraRpcs.js. 924 answered with the chainId they are filed under, 19 answered with a different one, and 1,708 were unreachable or errored and are ignored, since an unreachable host proves nothing.What this removes:
11Metadium Mainnet pointed atapi.metadium.com/dev, which returns 12.4002Fantom Testnet carriedfantom.api.onfinality.io/public, which returns 250, while the correct testnet url is one line away.1516,5124,16600,224400,224433and8691942025are the same shape.12124to12131are absent from the upstream chain list, so nothing rendered them;12123is BRC Chain Mainnet whose only entry washoodi.drpc.orgreturning 560048. Every url in that block is valid for the chain named in its own hostname, just filed in the wrong place, so removing the keys leaves upstream's own rpcs intact.2014and5577had no other rpc, so the key goes with the entry.Left alone deliberately:
2522Fraxtal Testnet. Both its endpoints now return 2523, which exists upstream as Fraxtal Hoodi Testnet, so whether they should move to 2523 or be dropped is your call rather than mine.Deletions only apart from one inline array element.
node tests/check-duplicate-keys.jspasses, the module still parses, and no key is left with an emptyrpcs.Fixes #3168