validate-chain-files runs against every file merged since a PR opened, and 8 registry files on main cannot pass it

[0xshubhs]

validate-chain-files.yml fails PRs on chain files those PRs never touched, and 8 files currently on
main cannot pass it. The two problems compound: the first decides who gets hit, the second decides
whether the run fails.

1. the changed-file list is "everything merged since the PR opened"

The workflow triggers on pull_request_target and computes:

git diff --name-only ${{ github.event.pull_request.base.sha }} ${{ github.sha }}

Under pull_request_target, github.sha is the base branch head, not the PR. So that diff is
base-when-the-PR-opened .. current main, which is every commit merged to main since the PR was
opened, and none of the PR's own commits.

On #3106, opened 2026-09-01 with base.sha 1640e92a, that window currently contains 27
constants/additionalChainRegistry/ files, all added by other people. The validator was handed all
27 and failed on two of them:

Validation failed for chainid-11941.js: Chain name should be an object
Validation failed for chainid-402.js: Chain chain is mandatory

Neither file is in #3106, whose diff is constants/extraRpcs.js and tests/check-duplicate-keys.js
only. The older the PR, the wider the window, which is why this shows up on the oldest open PR
touching extraRpcs.js and not on recent ones.

base.sha...head.sha with three dots, or the PR files API, would give the PR's own changes.

2. eight files on main fail the validator today

Replaying validateChainFile's own checks over all 511 registry files:

511 files   503 pass   8 FAIL

3  Chain icon is not a string      chainid-101001000.js, chainid-11166111.js, chainid-193939.js
2  Chain name should be an object  chainid-11941.js, chainid-1199.js
2  Chain networkId is mandatory    chainid-202599.js, chainid-210000.js
1  Chain chain is mandatory        chainid-402.js

Causes, and what each would need:

• icon as an object. Those three carry icon: { url, format, width, height } while
  stringCheck(data,'icon') wants a string. It looks deliberate rather than malformed, so this may be
  the validator being stricter than the format you actually want to accept. Your call which side
  changes; I have not touched them.
• features as plain strings. ["EVM Compatible", "MetaMask Supported"] hits
  features.forEach(f => stringCheck(f,'name',true)), whose first line rejects a non-object. Rewriting
  as [{ "name": "EVM Compatible" }, { "name": "MetaMask Supported" }] preserves the content exactly
  and is the form the other 509 files use.
• missing networkId. Both JuChain files. ethereum-lists has authoritative values:
  202599 -> networkId 202599, chain "JuChain", icon "ju-test" and
  210000 -> networkId 210000, chain "JuChain", icon "ju".
• missing chain. chainid-402.js (Actumic Mainnet). Not in ethereum-lists, so there is no
  upstream value to copy and I will not invent one. Its shortName is actumic; tell me what chain
  should read and I will add it.

reproducing the census

# replays stringCheck/numberCheck from .github/scripts/validate-chain-files.js
# over every constants/additionalChainRegistry/chainid-*.js

Happy to send a PR for the unambiguous subset (the two features rewrites plus the two JuChain
networkId values from upstream), which would clear 4 of the 8. The icon question and 402's chain
need a decision from you first, and fixing the workflow diff is the part that stops this recurring.

[0xshubhs]

Confirmed the diagnosis empirically: rebasing makes the check pass, with no change to either PR's
content.

I rebased both of my PRs that touch extraRpcs.js onto current main and force-pushed. The
synchronize event refreshed pull_request.base.sha to main's head, which empties the
base.sha .. github.sha window, so FILES_CHANGED came out empty and no unrelated chain files were
validated:

                 base.sha before   base.sha after   validate before   validate after
PR #3169         92784166b         4448ef013        fail              pass
PR #3106         1640e92ab         4448ef013        fail              pass

Both diffs are byte-identical across the rebase (#3169 still 1 insertion, 125 deletions in
extraRpcs.js; #3106 still -57 there and +53 in the test), and node tests/check-duplicate-keys.js
passes on both, reporting 2,972 urls checked with no duplicates. Both now sit at
validate=SUCCESS, reviewDecision=REVIEW_REQUIRED.

So the 8 invalid registry files never actually broke anything by themselves; what broke was being an
old PR. A rebase is a usable workaround for anyone else who hits this, but it only hides it: the next
PR to sit open for a few weeks while one of those 8 files lands will fail the same way, on files it
has never touched.

That leaves the two parts of this issue still worth doing: the base.sha...head.sha fix so the
window is the PR's own changes, and the 8 files so the validator can actually pass on them. I am
still happy to send the unambiguous four (the two features rewrites plus the two JuChain
networkId values from ethereum-lists) whenever you want them; the icon object question and 402's
missing chain are the two that need your call.