Skip to content

Fix/wobbliness on shift zoom #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
warm-coolguy wants to merge 2 commits into
base: next
Choose a base branch
from
Open

Fix/wobbliness on shift zoom #968

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f54675e
fix(core): use DragPan default condition on Desktop
warm-coolguy Sep 11, 2026
1134d91
Merge branch 'next' into fix/wobbliness-on-shift-zoom
warm-coolguy Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/core/utils/interactions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
import type { MapBrowserEvent } from 'ol'

import { platformModifierKeyOnly } from 'ol/events/condition'
import {
noModifierKeys,
platformModifierKeyOnly,
primaryAction,
} from 'ol/events/condition'
import {
DragPan,
KeyboardPan,
Expand Down Expand Up @@ -30,9 +34,11 @@ export function createPanAndZoomInteractions(
}
return [
new DragPan({
condition: function () {
// @ts-expect-error | As the DragPan is added to the interactions of the map, the 'this' context of the condition function should always be defined.
return hasSmallScreen ? this.getPointerCount() > 1 : true
condition: function (e) {
return hasSmallScreen
? // @ts-expect-error | As the DragPan is added to the interactions of the map, the 'this' context of the condition function should always be defined.
this.getPointerCount() > 1
: noModifierKeys(e) && primaryAction(e)
},
}),
new MouseWheelZoom({
Expand Down
Loading