Skip to content

Fix/wobbliness on shift zoom - #968

Open
warm-coolguy wants to merge 2 commits into
nextfrom
fix/wobbliness-on-shift-zoom
Open

warm-coolguy wants to merge 2 commits into
nextfrom
fix/wobbliness-on-shift-zoom

Conversation

@warm-coolguy

Copy link
Copy Markdown
Member

Summary

DragPan would also fire during DragBox interactions due to missing checks. DragPan#options.condition default value according to docs has been set as condition for non-small-screen devices.

Instructions for local reproduction and review

Run snowbox and Shift(hold)+Drag on via mouse. Check on mobile if panning still works.

Pull Request Checklist (for Assignee)

  • Functionality has been tested in Firefox, Chrome, Safari
  • Functionality has been tested on a smartphone

Relevant tickets, issues, et cetera

Resolves #965

@warm-coolguy warm-coolguy self-assigned this Sep 11, 2026
@warm-coolguy warm-coolguy added the bug Something isn't working label Sep 11, 2026
@warm-coolguy
warm-coolguy requested a review from a team September 11, 2026 10:45
@warm-coolguy
warm-coolguy changed the base branch from main to next September 11, 2026 10:45
@github-actions

Copy link
Copy Markdown
PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://Dataport.github.io/polar/pr-preview/pr-968/

Built to branch gh-pages at 2026-09-22 07:57 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@dopenguin dopenguin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extreme wobbliness on OL default shift zoom

2 participants