Skip to content

Fix compilation errors and warnings - #332

Open
DanielMarcos1 wants to merge 1 commit into
devfrom
jules-4610575985327991225-c0b0658e
Open

Fix compilation errors and warnings#332
DanielMarcos1 wants to merge 1 commit into
devfrom
jules-4610575985327991225-c0b0658e

Conversation

@DanielMarcos1

Copy link
Copy Markdown
Owner

This commit fixes several compilation errors preventing cargo check and cargo test from succeeding.

Changes include:

  • Fixed E0425 and E0433 errors in src/geometry/vector.rs by correctly importing wide::f32x4 for SIMD operations.
  • Resolved type placeholder issues in src/physics/world.rs's World struct, mapping them back to proper Rust types (Vector3d, f32, Polygon) under the new DOD structure.
  • Removed unused physics::rigid_body module imports in src/physics/world.rs.
  • Cleaned up several unnecessary mut bindings in world.rs and rigid_body.rs generating linter warnings.
  • Hushed an unused variable warning in gpu.rs by prefixing submission_index with an underscore (_submission_index).

The codebase now builds successfully with cargo test and cargo check.


PR created automatically by Jules for task 4610575985327991225 started by @DanielMarcos1

…d clean up warnings

Co-authored-by: DanielMarcos1 <99456595+DanielMarcos1@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant