Capture and check the logs of Simulation tests with @test_logs - #6087
Merged
Merged
Conversation
Since the move to ParallelTestRunner most tests share a single CI job, whose log is dominated by messages printed by the tests. In `test/simulation/simulation.jl` every `run!`, first `time_step!` and stop criterion call printed initialization, initial-time-step and stop messages. Wrap these calls in `@test_logs`, which both silences them and asserts the exact sequence of messages: the stop reason, that the `NaNChecker` fires during initialization, the order of progress-callback messages relative to the stop messages, and the previously untested warning emitted when `minimum_relative_step` skips a time step. Also drop the `@info "Testing ..."` banners, which are redundant with the testset names. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YT3BwDvhiaJUeJXHKwCb7A
This was referenced Sep 26, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6087 +/- ##
==========================================
+ Coverage 74.01% 75.25% +1.24%
==========================================
Files 428 434 +6
Lines 26420 27282 +862
==========================================
+ Hits 19554 20532 +978
+ Misses 6866 6750 -116
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
navidcy
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make tests less chatty and actually test more things.